Skip to content

[network_info_plus] Migrate Android part to Kotlin#1090

Merged
vbuberen merged 5 commits intomainfrom
refactor/network_info_plus
Sep 26, 2022
Merged

[network_info_plus] Migrate Android part to Kotlin#1090
vbuberen merged 5 commits intomainfrom
refactor/network_info_plus

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

Description

Continue migration of Plus Plugins Android parts to Kotlin. As in #666 tried did manual migration and did minor changes preserving existing behavior. As a side-effect fixed issue with getWifiBroadcast() to not return redundant / in front.

Also modernised the project to use latest Android dependencies and bumped targetSDK and compileSDK to 33. There were no network related changes between 31 and 33, so nothing breaking expected.

Related Issues

Closes #925
Closes #614

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Copy Markdown
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks super clean now

@vbuberen
Copy link
Copy Markdown
Collaborator Author

After finishing with other plugins going to get back to this one as we are using some deprecated things in this plugin.

@vbuberen vbuberen merged commit c8d2d63 into main Sep 26, 2022
@vbuberen vbuberen deleted the refactor/network_info_plus branch September 26, 2022 06:53
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: getWifiBroadcast returns address with "/" in front network_info_plus not working correctly in release version of the app

2 participants