[android_intent_plus] Fix fallback to implicit intent#1136
Merged
Conversation
vbuberen
commented
Oct 2, 2022
| if ("launch".equalsIgnoreCase(call.method)) { | ||
| sender.send(intent); | ||
|
|
||
| if (intent != null && !sender.canResolveActivity(intent)) { |
Collaborator
Author
There was a problem hiding this comment.
I have just moved this check from buildIntent() to be able to set package as null, so the system just opens a chooser.
miquelbeltran
approved these changes
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for #245 broke the functionality of safe fallback from explicit to implicit intent when package can't be resolved. This PR adds such functionality back.
Additionally updated Android Gradle plugin and used Gradle version.
Related Issues
Closes #919
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?