fix(package_info_plus): proper version.json url for files with special characters#2015
Merged
vbuberen merged 1 commit intoAug 2, 2023
Merged
Conversation
fhuonder
changed the title
fhuonder
force-pushed
the
wrong-versionjson-path
branch
from
1678c3f to
2a83e24
Compare
fhuonder
changed the title
fhuonder
force-pushed
the
wrong-versionjson-path
branch
from
2a83e24 to
7d6a844
Compare
fhuonder
changed the title
7 tasks
vbuberen
approved these changes
Aug 2, 2023
vbuberen
left a comment
vbuberen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks for adding tests as well. This fix will be released today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the regex that matches the URL for the version.json path generation.
The previous regex did not correctly recognize non-word characters in URLs and created a wrong version.json path.
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).