Skip to content

fix(package_info_plus)!: allow no page extension in versionJsonUrl on web#2381

Merged
vbuberen merged 2 commits into
fluttercommunity:mainfrom
NicolasDionB:fix_web_versionjson_path
Nov 20, 2023
Merged

fix(package_info_plus)!: allow no page extension in versionJsonUrl on web#2381
vbuberen merged 2 commits into
fluttercommunity:mainfrom
NicolasDionB:fix_web_versionjson_path

Conversation

@NicolasDionB

Copy link
Copy Markdown
Contributor

Description

This PR aims at fixing a scenario where we get version.json from the app page with no file extension on the web. Such an url would previously break the version.json url when trying to get it.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

There is a small breaking change as an url not ending with a slash would previously have been recognized as a folder, resulting in a different url. For exemple, given an app url "https://example.com/a/b/c?hello_world=true#/my-page", the version.json path would be:

@NicolasDionB NicolasDionB changed the title fix!(package_info_plus): allow no page extension in versionJsonUrl on web fix(package_info_plus): allow no page extension in versionJsonUrl on web Nov 17, 2023
@NicolasDionB NicolasDionB changed the title fix(package_info_plus): allow no page extension in versionJsonUrl on web fix(package_info_plus)!: allow no page extension in versionJsonUrl on web Nov 17, 2023
@vbuberen

Copy link
Copy Markdown
Collaborator

Thank you for your contribution!

@vbuberen vbuberen merged commit 32652b8 into fluttercommunity:main Nov 20, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong version.json path when last part of url isn't a folder

2 participants