fix(package_info_plus)!: allow no page extension in versionJsonUrl on web#2381
Merged
vbuberen merged 2 commits intoNov 20, 2023
Conversation
Collaborator
|
Thank you for your contribution! |
vbuberen
approved these changes
Nov 20, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at fixing a scenario where we get
version.jsonfrom the app page with no file extension on the web. Such an url would previously break theversion.jsonurl when trying to get it.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
!in the title as explained in Conventional Commits).There is a small breaking change as an url not ending with a slash would previously have been recognized as a folder, resulting in a different url. For exemple, given an app url "https://example.com/a/b/c?hello_world=true#/my-page", the version.json path would be: