Skip to content

feat(connectivity_plus)!: Migrate to package:web#2621

Merged
miquelbeltran merged 9 commits into
mainfrom
miquelbeltran/issue2600
Feb 28, 2024
Merged

feat(connectivity_plus)!: Migrate to package:web#2621
miquelbeltran merged 9 commits into
mainfrom
miquelbeltran/issue2600

Conversation

@miquelbeltran

@miquelbeltran miquelbeltran commented Feb 28, 2024

Copy link
Copy Markdown
Member

Description

  • Replace calls to dart:html by the equivalent with the package:web.
  • Tested on Chrome + macOS
  • Set web version to >=0.3.0 <=0.6.0 to be backwards compatible.
  • Set min Dart sdk version to 3.2.0 in package, as it is the min version of web 0.3.
  • Removed unused NetworkInformationApiConnectivityPlugin with the js dependency.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Potentially a breaking change, since it will require new package:web dependencies.

@miquelbeltran

miquelbeltran commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

The connectivity_plus class NetworkInformationApiConnectivityPlugin is not even used. I am considering removing it. The only reason the js dependency is here is because of this class.

@miquelbeltran miquelbeltran marked this pull request as ready for review February 28, 2024 15:35
@vbuberen

vbuberen commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

The connectivity_plus class NetworkInformationApiConnectivityPlugin is not even used. I am considering removing it.

Great finding. Sure, let's remove it along with js dependency.

@vbuberen vbuberen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good to me with range and Dart version bump.
Thanks for taking care of it.

@vbuberen

Copy link
Copy Markdown
Collaborator

Looks like it also closes #2598

@miquelbeltran miquelbeltran changed the title feat(connectivity_plus)!: Migrate to package:web 0.5.0 feat(connectivity_plus)!: Migrate to package:web Feb 28, 2024
@miquelbeltran miquelbeltran merged commit fbc8e61 into main Feb 28, 2024
@miquelbeltran miquelbeltran deleted the miquelbeltran/issue2600 branch February 28, 2024 19:06
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: (connectivity_plus): migrate to pkg:web from dart:html [Request]: Dependency JS Update

2 participants