Skip to content

fix(sensors_plus): resolve lint issues found during melos analyze#3845

Merged
vbuberen merged 1 commit into
fluttercommunity:mainfrom
mahendrimd:fix/sensors-plus-warnings
Jun 14, 2026
Merged

fix(sensors_plus): resolve lint issues found during melos analyze#3845
vbuberen merged 1 commit into
fluttercommunity:mainfrom
mahendrimd:fix/sensors-plus-warnings

Conversation

@mahendrimd

Copy link
Copy Markdown
Contributor

Description

  • Fix incorrect method overrides.
  • Add invalid_runtime_check_with_js_interop_types suppression in web_sensors.dart.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing. i run the flutter test on packages\sensors_plus\sensors_plus
  • The analyzer (flutter analyze) does not report any problems on my PR. The analyze does not report error
D:\...\sensors_plus\sensors_plus>flutter test
00:05 +5: All tests passed!

D:\...\sensors_plus\sensors_plus>flutter analyze
Analyzing sensors_plus...
No issues found! (ran in 1.7s)

melos run analyze
melos run analyze
  └> melos exec -c 5 -- \
       dart analyze . --fatal-infos
     └> RUNNING

$ melos exec
  └> dart analyze . --fatal-infos
     └> RUNNING (in 25 packages)

------------------------------------------------------------------------------------------------------------------------
...
[sensors_plus]: Analyzing ....
[sensors_plus]: No issues found!
[sensors_plus_example]: Analyzing ....
[sensors_plus_example]: No issues found!
[sensors_plus_platform_interface]: Analyzing ....
[sensors_plus_platform_interface]: No issues found!
...

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

- Fix incorrect method overrides.
- Add `invalid_runtime_check_with_js_interop_types` suppression in `web_sensors.dart`.
@mahendrimd mahendrimd force-pushed the fix/sensors-plus-warnings branch from c43478a to bdedd9a Compare May 28, 2026 05:41
@mahendrimd

mahendrimd commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

The CI run looks great, the lint warnings for sensors_plus have been resolved.

To get the all_plugins workflow fully greenlit, I am going to open a follow-up PR later to apply the same suppression to the lint warning found in share_plus.

@vbuberen vbuberen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

Part of changes seems related to #3735

@vbuberen vbuberen merged commit c6511c0 into fluttercommunity:main Jun 14, 2026
11 of 15 checks passed
@mahendrimd mahendrimd deleted the fix/sensors-plus-warnings branch June 19, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Compile]: dart analyze output override warning on sensors_plus

2 participants