Skip to content

[network_info_plus] Fix issue #431 network_info_plus: 'net/route.h' file not found when building for iOS emulator#451

Merged
mhadaily merged 4 commits intofluttercommunity:mainfrom
phan-dev:main
Oct 1, 2021
Merged

[network_info_plus] Fix issue #431 network_info_plus: 'net/route.h' file not found when building for iOS emulator#451
mhadaily merged 4 commits intofluttercommunity:mainfrom
phan-dev:main

Conversation

@phan-dev
Copy link
Copy Markdown
Contributor

@phan-dev phan-dev commented Sep 10, 2021

Description

Fix issue #431 network_info_plus: 'net/route.h' file not found when building for iOS emulator

Related Issues

#431

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Fix issue fluttercommunity#431 network_info_plus: 'net/route.h' file not found when building for iOS emulator
@phan-dev
Copy link
Copy Markdown
Contributor Author

#431

@phan-dev
Copy link
Copy Markdown
Contributor Author

@lucasratske
Thank you for approval!
But there are some checks were cancelled. How can we re-run them again?

@diegotori
Copy link
Copy Markdown

@lucasratske can we prioritize this issue since I can't build my app that uses this library with Flutter 2.5? Thanks in advance.

@diegotori
Copy link
Copy Markdown

@mhadaily Sorry to be a bother, but this one should also be added to the next release urgently. Thanks in advance.

Also, if you're in need of someone to release builds, add me on pub.dev at diegotoridoesandroid@gmail.com. I'm willing to help release builds to spread out the burden if you want.

@mhadaily mhadaily self-requested a review October 1, 2021 14:17
@mhadaily mhadaily added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 1, 2021
Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 1, 2021

@phan-dev, can you please add a CHANGELOG and bump a path version for network_plus_info? I'll merge and release after that.

Thank you for the PR

@phan-dev
Copy link
Copy Markdown
Contributor Author

phan-dev commented Oct 1, 2021

@mhadaily
Thank you for review!
Do you mean I add CHANGELOG for the new version 1.1.1 ?

@phan-dev phan-dev changed the title Fix issue #431 network_info_plus: 'net/route.h' file not found when building for iOS emulator [network_info_plus] Fix issue #431 network_info_plus: 'net/route.h' file not found when building for iOS emulator Oct 1, 2021
@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 1, 2021

yes please

here https://github.com/fluttercommunity/plus_plugins/blob/main/packages/network_info_plus/network_info_plus/CHANGELOG.md

@mhadaily mhadaily merged commit d387cae into fluttercommunity:main Oct 1, 2021
@phan-dev
Copy link
Copy Markdown
Contributor Author

phan-dev commented Oct 1, 2021

@mhadaily
Thank you!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants