Skip to content

migrate integration_test to flutter sdk#466

Merged
mhadaily merged 3 commits intofluttercommunity:mainfrom
alexbatalov:fix-integration-test-version
Oct 1, 2021
Merged

migrate integration_test to flutter sdk#466
mhadaily merged 3 commits intofluttercommunity:mainfrom
alexbatalov:fix-integration-test-version

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

Update integration_test to Flutter SDK.

Related Issues

#465

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@juliansteenbakker
Copy link
Copy Markdown
Contributor

This is blocking #442, and also preventing the CI pipeline from upgrading from flutter-version: "2.2.1" to a recent version like 2.5.1. Can this be merged?

@mhadaily mhadaily added the Hacktoberfest Issues taking part in Hacktoberfest label Oct 1, 2021
@mhadaily mhadaily self-requested a review October 1, 2021 14:20
@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 1, 2021

@alexbatalov great PR. thank you. Can you just add a changelog and bump a patch version on all of these plugins? I'll merge and release right away.

Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added version and changelog

LGTM

@mhadaily mhadaily merged commit 2706be7 into fluttercommunity:main Oct 1, 2021
@alexbatalov alexbatalov deleted the fix-integration-test-version branch October 13, 2021 13:35
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants