Skip to content

Fix alarm_manager_plus for Android 12+#486

Merged
mhadaily merged 3 commits intofluttercommunity:mainfrom
ThexXTURBOXx:main
Oct 3, 2021
Merged

Fix alarm_manager_plus for Android 12+#486
mhadaily merged 3 commits intofluttercommunity:mainfrom
ThexXTURBOXx:main

Conversation

@ThexXTURBOXx
Copy link
Copy Markdown
Contributor

Description

This PR fixes android_alarm_manager_plus for Android 12+ by adding the FLAG_IMMUTABLE to the PendingIntents.

Related Issues

Fixes #477

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily mhadaily self-requested a review October 2, 2021 10:20
@mhadaily mhadaily added Hacktoberfest Issues taking part in Hacktoberfest android_alarm_manager_plus labels Oct 2, 2021
@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Oct 2, 2021

Seems formatting is failing.

Could you please add a changelog and bump the package as well?

thanks.

@ThexXTURBOXx
Copy link
Copy Markdown
Contributor Author

Yes, give me a few minutes. I will fix it asap! :)

@ThexXTURBOXx
Copy link
Copy Markdown
Contributor Author

@mhadaily The issues should be fixed now :)

Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SalishKumar
Copy link
Copy Markdown

please fix this

@ThexXTURBOXx
Copy link
Copy Markdown
Contributor Author

@SalishKumar There is already a PR for this. Apologies for the mistakes, I am almost certain I just forgot to git add * again

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crashes when targeting API 31

3 participants