Skip to content

Update Melos and CD/CI#489

Merged
mhadaily merged 26 commits intomainfrom
fix_integration_test_ci
Oct 5, 2021
Merged

Update Melos and CD/CI#489
mhadaily merged 26 commits intomainfrom
fix_integration_test_ci

Conversation

@mhadaily
Copy link
Copy Markdown
Member

@mhadaily mhadaily commented Oct 2, 2021

Description

Addressing a few issues and add more jobs in our CD/CI

Related Issues

fixes #488

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily mhadaily self-assigned this Oct 2, 2021
@mhadaily mhadaily added CI/CD Everything related to automated builds and deployments enhancement New feature or request Hacktoberfest Issues taking part in Hacktoberfest labels Oct 2, 2021
@juliansteenbakker
Copy link
Copy Markdown
Contributor

@mhadaily mhadaily changed the title Update Melos and CD/CI [WIP, DO NOT MERGE] Update Melos and CD/CI Oct 3, 2021
@mhadaily
Copy link
Copy Markdown
Member Author

mhadaily commented Oct 3, 2021

FYI, you can mark a PR as a draft so it can't be merged yet 😉

haha, I know, but it was ready to merge actually. thanks for the heads up anyway

@mhadaily mhadaily requested a review from elias8 October 3, 2021 10:01
@juliansteenbakker
Copy link
Copy Markdown
Contributor

Will this also update the CI street to flutter 2.5(.2)? Right now #442 is failing because i've already migrated some tests to 2.5.2.

@mhadaily
Copy link
Copy Markdown
Member Author

mhadaily commented Oct 3, 2021

Yes, it will

Comment thread melos.yaml Outdated
Comment thread melos.yaml Outdated
Comment thread .github/workflows/scripts/install-tools.sh
@mhadaily mhadaily requested a review from elias8 October 3, 2021 20:23
@mhadaily
Copy link
Copy Markdown
Member Author

mhadaily commented Oct 3, 2021

@elias8 let me know if this sounds good to you.

There are a few things we need to fix later
1- fixing integration tests
2- fixing build on Linux and windows
3- add running tests on all three platforms.

Copy link
Copy Markdown
Member

@elias8 elias8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@elias8
Copy link
Copy Markdown
Member

elias8 commented Oct 4, 2021

There are a few things we need to fix later
1- fixing integration tests
2- fixing build on Linux and windows
3- add running tests on all three platforms.

Sounds good @mhadaily

@mhadaily mhadaily merged commit a4af5c6 into main Oct 5, 2021
@mhadaily mhadaily deleted the fix_integration_test_ci branch October 5, 2021 01:30
@juliansteenbakker
Copy link
Copy Markdown
Contributor

This PR added google-java-format formatting, however this is not default in android studio. Maybe it's a good idea to add a section to the readme explaining on how to format files correctly since it's not really straight forward.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI/CD Everything related to automated builds and deployments enhancement New feature or request Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[all]] Transition of platform channel test interfaces to flutter_test package

3 participants