fix(android_alarm_manger_plus): Periodic alarm becomes inexact after some time#496
Merged
miquelbeltran merged 5 commits intofluttercommunity:mainfrom Oct 5, 2021
Merged
Conversation
miquelbeltran
approved these changes
Oct 5, 2021
Member
miquelbeltran
left a comment
There was a problem hiding this comment.
Looks good to me, exposing more params is always good!
Can you fix the merge conflict? Then we will proceed with the merge and release.
Thank you!
Member
|
I fixed the merge conflict, will merge once CI is done. |
Collaborator
Author
|
Sure, I can fix. You were pretty quick though 😀 |
Member
|
merged and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR should address issue with periodic alarms which have
exact=truelosing accuracy after some time. I believe it is something connected with power optimisations done by different Android versions.While looking through plugin code I saw that
periodicis inconsistent withoneShotcalls, since inoneShotusers haveallowWhileIdleparameter which should call setAndAllowWhileIdle function fromAlarmManagerCompatclass instead of justset. It means that even withexactset to true periodic alarms were never set to allow while the phone is in idle, which might be the case reported in #487.It seems that the issue reporter uses Samsung and as an owner of Samsung device as well I know that their implementation of power management is quite aggressive and suspends apps, which aren't used for some days.
Note that this PR is based on #494, because otherwise I couldn't build the example app.
Related Issues
This PR potentially closes #487
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?