Skip to content

fix(android_alarm_manager_plus): Remove deprecated method registerWith#499

Merged
miquelbeltran merged 2 commits intofluttercommunity:mainfrom
nohli:remove-android-v1-embedding
Oct 5, 2021
Merged

fix(android_alarm_manager_plus): Remove deprecated method registerWith#499
miquelbeltran merged 2 commits intofluttercommunity:mainfrom
nohli:remove-android-v1-embedding

Conversation

@nohli
Copy link
Copy Markdown
Member

@nohli nohli commented Oct 5, 2021

Description

The recently merged PR #495 didn't include the removal for this package, because the tests were failing (and to not have too much overhead, I reverted the changes).

This PR does the same as #495, but for android_alarm_manger_plus, and the checks are successful this time (couldn't check the reason locally because the tests use melos, maybe just had to add static in line 43/44).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Copy Markdown
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miquelbeltran miquelbeltran self-assigned this Oct 5, 2021
@miquelbeltran miquelbeltran merged commit 2d4c748 into fluttercommunity:main Oct 5, 2021
@miquelbeltran
Copy link
Copy Markdown
Member

merged and published

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants