fix(android_alarm_manager_plus): Remove deprecated method registerWith#499
Merged
miquelbeltran merged 2 commits intofluttercommunity:mainfrom Oct 5, 2021
nohli:remove-android-v1-embedding
Merged
fix(android_alarm_manager_plus): Remove deprecated method registerWith#499miquelbeltran merged 2 commits intofluttercommunity:mainfrom nohli:remove-android-v1-embedding
miquelbeltran merged 2 commits intofluttercommunity:mainfrom
nohli:remove-android-v1-embedding
Conversation
…AG static, update changelog and readme
Member
|
merged and published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The recently merged PR #495 didn't include the removal for this package, because the tests were failing (and to not have too much overhead, I reverted the changes).
This PR does the same as #495, but for
android_alarm_manger_plus, and the checks are successful this time (couldn't check the reason locally because the tests usemelos, maybe just had to addstaticin line 43/44).Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?