Skip to content

Update debug logging#552

Merged
miquelbeltran merged 7 commits intofluttercommunity:mainfrom
vbuberen:update/debug_log
Oct 13, 2021
Merged

Update debug logging#552
miquelbeltran merged 7 commits intofluttercommunity:mainfrom
vbuberen:update/debug_log

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

Description

Re-opening #538, because can't agree that it was just a duplicate of #537. I mentioned in #538 that it happened that we both worked on the same thing, but I believe that my version is a proper usage for developer.log(), since I use both error and stacktrace parameters provided by log() to have a better output in IDEs. Here is an example, where I added 2 lines to one of examples to show the difference in outputs:
Screenshot 2021-10-12 at 15 01 31

Note that the first one is how all logs are shown currently with #537 merged with just a plain string. On the second line I passed the same batteryLevel param as error to show that it is shown in a more informative way.

Additionally, #538 added some more logs in places where they were missing.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@vbuberen vbuberen changed the title Update/debug log Update debug logging Oct 12, 2021
@miquelbeltran
Copy link
Copy Markdown
Member

No worries, we can merge this one on top with improvements. I saw some analysis issues in the CI, once those are resolved I will merge this one. Thank you!

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 12, 2021
@miquelbeltran miquelbeltran merged commit 1bcb25d into fluttercommunity:main Oct 13, 2021
@miquelbeltran
Copy link
Copy Markdown
Member

thank you!

@vbuberen vbuberen deleted the update/debug_log branch October 13, 2021 10:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants