Update debug logging#552
Merged
miquelbeltran merged 7 commits intofluttercommunity:mainfrom Oct 13, 2021
Merged
Conversation
Member
|
No worries, we can merge this one on top with improvements. I saw some analysis issues in the CI, once those are resolved I will merge this one. Thank you! |
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-opening #538, because can't agree that it was just a duplicate of #537. I mentioned in #538 that it happened that we both worked on the same thing, but I believe that my version is a proper usage for

developer.log(), since I use botherrorandstacktraceparameters provided bylog()to have a better output in IDEs. Here is an example, where I added 2 lines to one of examples to show the difference in outputs:Note that the first one is how all logs are shown currently with #537 merged with just a plain string. On the second line I passed the same batteryLevel param as
errorto show that it is shown in a more informative way.Additionally, #538 added some more logs in places where they were missing.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?