Skip to content

[Github Actions] Separate Flutter Analyze from pub.dev validation#583

Merged
miquelbeltran merged 1 commit intofluttercommunity:mainfrom
vbuberen:patch-2
Oct 27, 2021
Merged

[Github Actions] Separate Flutter Analyze from pub.dev validation#583
miquelbeltran merged 1 commit intofluttercommunity:mainfrom
vbuberen:patch-2

Conversation

@vbuberen
Copy link
Copy Markdown
Collaborator

Description

This PR separates Flutter analyze step from validations if pub.dev requirements are met for publishing. This change will provide more clarity when something fails from publishing point of view or the code analyzer.

For further updates for even better granularity I would move more operations to corresponding plugins workflows and run all_plugins workflows only after merging the PR, while run all validations/checks in the corresponding plugin related workflow.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@vbuberen vbuberen changed the title Separate Flutter Analyze from pub.dev validation [Github Actions] Separate Flutter Analyze from pub.dev validation Oct 26, 2021
@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 27, 2021
Copy link
Copy Markdown
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@miquelbeltran miquelbeltran merged commit ad9f79c into fluttercommunity:main Oct 27, 2021
@vbuberen vbuberen deleted the patch-2 branch February 20, 2022 14:48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants