[examples] explicitly override deps#587
Merged
miquelbeltran merged 1 commit intofluttercommunity:mainfrom Nov 3, 2021
Merged
Conversation
9 tasks
miquelbeltran
approved these changes
Nov 3, 2021
Member
miquelbeltran
left a comment
There was a problem hiding this comment.
Thanks for the extended explanation, the idea makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR explicitly specify platform-specific implementation paths in example apps.
The reason is the nature of federated plugins. In example apps main package is always specified via path. In case of unfederated plugin, it's platform-specific implementations are already part of the main package and will be picked up when building example (thus accounting for changes in any platform implementation). However with federated plugins main package has it's platform-specific implementations as version-locked dependencies. Building example app takes main package via path (thus accounting for changes Android/iOS implementations), but other platform implementations are resolved to published versions in pub ignoring current changes.
Specifying paths explicitly fixes CI's
pub_get_checkjob and resolves failing check in #571 because it does not depend on runningmelos. As far as get this repo's CI configuration is built after flutterfire which uses same checks and build steps. See firebase_core/example how they do the same. A more complex example is firebase_database/example in which they specify platform-specific implementations for transitive dependencies for packages in the same monorepo.It also removes
argsfrom examples'dependency_overrides. Some packages don't have it and they run perfectly fine. Not sure what it was used for, so I've removed it.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?