Skip to content

[device_info_plus_macos] fix compiler warnings#588

Merged
miquelbeltran merged 1 commit intofluttercommunity:mainfrom
alexbatalov:device-info-plus-macos-fix-warnings
Nov 3, 2021
Merged

[device_info_plus_macos] fix compiler warnings#588
miquelbeltran merged 1 commit intofluttercommunity:mainfrom
alexbatalov:device-info-plus-macos-fix-warnings

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

Fixes #569

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily mhadaily added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 31, 2021
Copy link
Copy Markdown
Member

@elias8 elias8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@miquelbeltran miquelbeltran merged commit d706252 into fluttercommunity:main Nov 3, 2021
@alexbatalov alexbatalov deleted the device-info-plus-macos-fix-warnings branch November 4, 2021 06:40
@nohli nohli mentioned this pull request Dec 29, 2021
9 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

device_info_plus plugin is producing build warnings on macos

4 participants