Skip to content

[device_info_plus] update versions for publishing#663

Merged
mhadaily merged 2 commits intofluttercommunity:mainfrom
alexbatalov:device-info-plus-auto-registration
Jan 1, 2022
Merged

[device_info_plus] update versions for publishing#663
mhadaily merged 2 commits intofluttercommunity:mainfrom
alexbatalov:device-info-plus-auto-registration

Conversation

@alexbatalov
Copy link
Copy Markdown
Contributor

Description

Right now using published versions of device_info_plus on Windows and Linux fails with Flutter 2.8.1. #574 and #598 needs publishing. Fixes #646.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Jan 1, 2022

@nohli should we merge this and release it? if so, then how about this one? #671

@nohli
Copy link
Copy Markdown
Member

nohli commented Jan 1, 2022

@mhadaily I would merge it. Since the other PR is just updating the changelog for changes that are already merged, I will then rebase it, so it can be merged, and then we release a new version including all PRs? What do you think?

Happy New Year! 😊

@mhadaily
Copy link
Copy Markdown
Member

mhadaily commented Jan 1, 2022

@nohli Happy new year too! sounds good. let's do it

Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhadaily mhadaily merged commit d321baa into fluttercommunity:main Jan 1, 2022
@alexbatalov alexbatalov deleted the device-info-plus-auto-registration branch January 19, 2022 12:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[device_info_plus] UnimplementedError when fetching info on Linux

3 participants