Update CONTRIBUTING.md#672
Merged
mhadaily merged 5 commits intofluttercommunity:mainfrom Jan 1, 2022
nohli:update_contributing_guidelines
Merged
Update CONTRIBUTING.md#672mhadaily merged 5 commits intofluttercommunity:mainfrom nohli:update_contributing_guidelines
mhadaily merged 5 commits intofluttercommunity:mainfrom
nohli:update_contributing_guidelines
Conversation
vbuberen
approved these changes
Dec 29, 2021
Collaborator
vbuberen
left a comment
There was a problem hiding this comment.
Maybe we could also mention how we approach versioning?
This link should work, I believe: https://semver.org/
vbuberen
approved these changes
Dec 29, 2021
Contributor
|
@nohli Please also update PR template, as now it is clearly states :
|
Member
Author
|
@alexbatalov good finding, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the changelog to make it more clear that PRs should update the version number.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?