Skip to content

Update CONTRIBUTING.md#672

Merged
mhadaily merged 5 commits intofluttercommunity:mainfrom
nohli:update_contributing_guidelines
Jan 1, 2022
Merged

Update CONTRIBUTING.md#672
mhadaily merged 5 commits intofluttercommunity:mainfrom
nohli:update_contributing_guidelines

Conversation

@nohli
Copy link
Copy Markdown
Member

@nohli nohli commented Dec 29, 2021

Description

Update the changelog to make it more clear that PRs should update the version number.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Copy Markdown
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also mention how we approach versioning?
This link should work, I believe: https://semver.org/

@alexbatalov
Copy link
Copy Markdown
Contributor

@nohli Please also update PR template, as now it is clearly states :

Updating the pubspec.yaml and changelogs is not required.

@nohli
Copy link
Copy Markdown
Member Author

nohli commented Dec 30, 2021

@alexbatalov good finding, done

Copy link
Copy Markdown
Member

@mhadaily mhadaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@mhadaily mhadaily merged commit b6b294c into fluttercommunity:main Jan 1, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants