Skip to content

[ReadMe change] Fix package name not being in title format#674

Closed
Brendan-H wants to merge 1 commit intofluttercommunity:mainfrom
Brendan-H:patch-1
Closed

[ReadMe change] Fix package name not being in title format#674
Brendan-H wants to merge 1 commit intofluttercommunity:mainfrom
Brendan-H:patch-1

Conversation

@Brendan-H
Copy link
Copy Markdown

@Brendan-H Brendan-H commented Dec 31, 2021

For android_alarm_manager_plus

Description

At the top of the readme, android_alarm_manager_plus has a '#' in front of it, but since there wasn't a new line between that and the flutter favorite image, the package name was left in the body text style with a hashtag in front of it rather than being converted to the title 1 format.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x ] All existing and new tests are passing.
  • [ x] I updated/added relevant documentation (doc comments with ///).
  • [ x] The analyzer (flutter analyze) does not report any problems on my PR.
  • [ x] I read and followed the Flutter Style Guide.
  • [ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [ x] No, this is not a breaking change.

At the top of the readme, android_alarm_manager_plus has a '#' in front of it, but since there wasn't a new line between that and the flutter favorite image, the package name was left in the body text style with a hashtag in front of it rather than being converted to title 1 format.
@vbuberen
Copy link
Copy Markdown
Collaborator

vbuberen commented Jan 1, 2022

Thanks for your contribution. However, there is already another PR which modifies README files #673
And this PR has the change you made as well.

@vbuberen
Copy link
Copy Markdown
Collaborator

vbuberen commented Jan 6, 2022

Closing this PR in favor of #673 as that PR was opened earlier and already has the change suggested by this PR.

@vbuberen vbuberen closed this Jan 6, 2022
@Brendan-H Brendan-H deleted the patch-1 branch February 13, 2022 21:27
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants