[share_plus] minSdkVersion 16 & graceful fallback#800
[share_plus] minSdkVersion 16 & graceful fallback#800miquelbeltran merged 4 commits intofluttercommunity:mainfrom Coronon:main
Conversation
|
The conflicts are due to #797. I will resolve them tonight (mainly formatting). Update: rebased |
|
Thanks! The original share method, could it be replaced by the one with the result? There's no difference except for the return type, which was |
|
Did not think about that - yeah, that would definitely simplify the API. The only problem I see is people not awaiting the "old" |
vbuberen
left a comment
There was a problem hiding this comment.
Left a few comments on namings.
What we are currently missing is updates to docs, which appear on Plus plugins website.
Would be good if you also modify https://github.com/fluttercommunity/plus_plugins/blob/main/docs/share_plus/usage.mdx to mention new methods and description about fallback on unsupported platforms.
|
Also added Will commit & push when EDIT: pushed |
@Coronon already touched on it a bit, but there's a difference in behavior between |
vbuberen
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this contribution!
Would like to wait for a review from Miguel as he was the person, who started reviewing this PR.
|
LGTM too, I will go ahead and merge & release |
|
I'm still getting this issue and android always return null in raw |
Description
minSdkVersionback to 16 and dynamically determine support forshareWithResultat runtimeshareWithResultshareWithResultRelated Issues
Closes #789
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?