Add missing defer summarize(req) in UninstallRemediation#1491
Open
SebTardif wants to merge 1 commit into
Open
Conversation
UninstallRemediation is the only action reconciler that does not call defer summarize(req). All other reconcilers (Install, Upgrade, Test, Uninstall, Unlock, RollbackRemediation) include this deferred call to propagate sub-conditions into the top-level Ready condition. Without this call, the Ready condition is never updated after an uninstall remediation, leaving a stale status until the next reconciliation pass. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Member
|
Thanks for the patch. Double checked things, and However, before this can be merged, please add a test in Also: if this work was assisted by an LLM, please add the appropriate trailer to the commit per https://github.com/fluxcd/helm-controller?tab=contributing-ov-file#ai-coding-assistants-guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UninstallRemediation.Reconcileis the only action reconciler that does not calldefer summarize(req). All six other reconcilers (Install,Upgrade,Test,Uninstall,Unlock,RollbackRemediation) include this call.Without it, the
Readycondition is never updated after an uninstall remediation, andObservedPostRenderersDigest/ObservedCommonMetadataDigestare not refreshed.Closes #1488
Changes
One-line addition:
defer summarize(req)after the variable block, matching all other reconcilers.Verification
go build ./...passesgo vet ./...passes