Fix support for public.ecr.aws - #938
Merged
Merged
Conversation
Member
Author
|
I was able to test this fix by building the Without authentication: With authentication (takes a while to run, probably because it's making several calls which otherwise would get rate-limited without authentication like shown above): |
matheuscscp
force-pushed
the
public-ecr
branch
2 times, most recently
from
June 7, 2025 13:22
c497530 to
966632b
Compare
Member
Author
|
@stefanprodan Please attach this policy to the IAM Role used by the aws integration tests GitHub Action workflow so we can push to public ECR: |
stefanprodan
reviewed
Jun 8, 2025
Comment on lines
+26
to
+30
| resource "aws_ecrpublic_repository" "test_ecr_public" { | ||
| repository_name = local.name | ||
| tags = var.tags | ||
| force_destroy = true | ||
| } |
Member
There was a problem hiding this comment.
Do we clean this up at the end of the CI run?
Member
Author
There was a problem hiding this comment.
Yes, on terraform destroy. But we may need to add code in the reaper, same for GCP WI pools and providers
Member
|
I've added Elastic Container Registry Public with Full access to the |
Member
Author
|
@stefanprodan Can you please add also a statement allowing |
Member
Author
|
I remembered I have access to AWS and added |
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Member
Author
|
Finally passed: https://github.com/fluxcd/pkg/actions/runs/15534292205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested the current code for public.ecr.aws and it doesn't work. It's probably because public ECR has a different endpoint and we were trying to reach it through the Go SDK for normal ECR, but there's a dedicated Go SDK for public ECR. This PR is fixing this by using the appropriate Go SDK.
xref: #936