Expose OCI origin revision in events - #2127
Open
ruslan-shaydullin wants to merge 1 commit into
Open
Conversation
OCI artifacts can record their source revision in the org.opencontainers.image.revision annotation. Include that value in successful events so notification consumers can correlate an artifact with its source commit. Keep the existing artifact revision unchanged and omit the extra event metadata when the annotation is empty. Signed-off-by: Ruslan Shaydullin <shaydullin.r.d@outlook.com>
Member
|
How does this affect kustomize-controller and helm-controller since they inject the originRevision on their own. Will it end up as a duplicate? |
Member
The controllers emit independent events. source-controller will have its own messages, reasons, object kind, etc. I'd not call this a duplicate. The Alert API allows filtering which events you want to propagate to the Provider, so this LGTM. |
matheuscscp
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCI artifacts can record their source revision in the
org.opencontainers.image.revisionannotation. This forwards that value assource.toolkit.fluxcd.io/originRevisionon successful OCIRepository events,allowing notification consumers to correlate an artifact with its source
commit.
The existing artifact revision and event message remain unchanged. The extra
event metadata is omitted when the annotation is empty or absent.
Closes fluxcd/notification-controller#1284
Testing
go test ./internal/controller -run '^TestOCIRepositoryReconciler_notify$' -count=1go test -race ./internal/controller -run '^TestOCIRepositoryReconciler_notify$' -count=1go vet ./...cd api && go vet ./...git diff --check