tests: Fix flakiness of git related tests - #686
Merged
Conversation
This ensures that no host specific git configuration is pulled in while testing. One such example would be "init.defaultBranch" which is set to "main" on some hosts, which then causes tests to fail as they keep looking for "master" branches. Signed-off-by: Alexander Block <ablock84@gmail.com>
I assume using "interval" for timeouts was an accident and "timeout" was actually meant to be used. This also fixes flakiness of tests. Signed-off-by: Alexander Block <ablock84@gmail.com>
codablock
force-pushed
the
fix-git-tests
branch
from
April 25, 2022 12:30
c2f3664 to
fa09aa2
Compare
pjbgf
reviewed
Apr 25, 2022
pjbgf
requested changes
Apr 25, 2022
pjbgf
left a comment
pjbgf
left a comment
Member
There was a problem hiding this comment.
Tiny nit, apart from that LGTM.
pjbgf
approved these changes
Apr 25, 2022
pjbgf
left a comment
pjbgf
left a comment
Member
There was a problem hiding this comment.
Thank you @codablock for working on this. 🙇
LGTM!
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the individual commits of this PR.