fix: add task config to version hash calculation#2417
Closed
ddl-rliu wants to merge 2 commits into
Closed
Conversation
Contributor
|
FYI there's a failing test b/c the mocked call isn't expecting the new param Basically the line at needs to be updated for theNone at the end
|
e633838 to
4f3e49f
Compare
ddl-rliu
commented
May 15, 2024
| LegacyConfigEntry(SECTION, "ca_cert_file_path"), YamlConfigEntry("admin.caCertFilePath") | ||
| ) | ||
| HTTP_PROXY_URL = ConfigEntry(LegacyConfigEntry(SECTION, "http_proxy_url"), YamlConfigEntry("admin.httpProxyURL")) | ||
| VERSION_HASH_SKIP_TASK_CONFIG = ConfigEntry(LegacyConfigEntry(SECTION, "version_hash_skip_task_config"), YamlConfigEntry("admin.versionHashSkipTaskConfig", bool)) |
Contributor
Author
There was a problem hiding this comment.
Is it preferred to gate this behavior behind config? If so, it likely doesn't belong in the PlatformConfig section – happy to move it somewhere else.
Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
4f3e49f to
3ff0b62
Compare
Contributor
Author
|
Closing in favor of #2428 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5364
Why are the changes needed?
Failed to register a workflow if users update the task config – especially in the case of custom tasks
What changes were proposed in this pull request?
hash should be calculated from the task config
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Tangentially related PRs:
flyteorg/flyte#4904
#2356
#2120
Docs link