Fix errors in packages tests - #3
Open
fmanno wants to merge 2 commits into
Open
Conversation
[Linux/macOS] Fix data races: Move the watcher structure cleanup to the exit branch of the watcher observe method.
fmanno
force-pushed
the
fix-packages-tests
branch
from
April 12, 2017 18:34
1c01837 to
ab63ce0
Compare
[linux] Increased delay before checking in TestWatchDir to see if it makes the test pass in Linux environments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Linux/macOS] Fix data races:
Move the watcher structure cleanup to the
exit branch of the watcher observe method.
[all] Fix error handling of TestOpenProject:
If the result of w.OpenProject was nil. The test
was exploding