Merged
Conversation
fnc12
requested changes
Aug 3, 2020
Owner
fnc12
left a comment
fnc12
left a comment
There was a problem hiding this comment.
Two issues:
- linux is still failing https://travis-ci.org . If it is not related to this PR we can skip it for now for you need to fix it. Or I can remove your old commit which broke linux CI compilation;
- please remove beerpay footer
Contributor
Author
|
@fnc12 Where can I see the failing travis build? Can you enable it here, so I can see the output? Otherwise it's hard to fix |
Contributor
Author
Why doesn't it show up here? |
Contributor
Author
|
So I just had a look we need cmake 3.14 in order for this to work. But travis currently does only support cmake 3.12 ... ubuntu 20.04 is on the way for travis, but not currently available yet. |
Owner
Don't know. I need to investigate it. |
Contributor
Author
|
Fixed, should be alright now! |
Owner
|
thank you |
This was referenced Aug 3, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I updated the docs and bumped the cmake version, which should fix the travis issue. How can I enable travis here, so I can see if the issue is actually resolved?