86b7h9kmt - fix: replace hidden html string for empty string

[ghost]

ref: https://app.clickup.com/t/86b7h9kmt

86b7h9kmt - fix: replace hidden html string for empty string

Changelog

• Validate html dirty string and replace its value for an empty string to trigger validation.

Links

86b7h9kmt - User is able to save without filling out mandatory field

Evidence

2025-12-24_11-06-02.mp4

Summary by CodeRabbit

• Bug Fixes
  • Text editor now correctly recognizes and clears empty content (e.g., editor empty HTML becomes an empty value) so form submission and field state behave as expected.
• Tests
  • Added unit tests to validate empty vs. non-empty editor content normalization.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[ghost]

@smarcet Don't forget about this PR.

[smarcet]

@niko-exo please review commnets

[coderabbitai]

📝 Walkthrough

Walkthrough

The Formik text editor's onChange now routes the editor HTML through a new normalizeJoditEmpty utility which returns an empty string for empty-like HTML; that normalized value is then used to update the Formik field.

Changes

Cohort / File(s)	Summary
Formik component change src/components/inputs/formik-text-editor.js	Import and call normalizeJoditEmpty in the editor's onChange handler so the value passed to Formik is normalized (empty-like HTML → "") before calling setFieldValue.
New utility + tests src/components/inputs/utils/normalizeJoditEmpty.js, src/components/inputs/utils/__tests__/normalizeJoditEmpty.test.js	Add normalizeJoditEmpty (parses HTML and returns "" when body text is empty) and accompanying unit tests verifying empty-like HTML normalizes to "" and non-empty HTML remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Editor as JoditEditor
    participant Norm as normalizeJoditEmpty
    participant Formik

    User->>Editor: type / edit content
    Editor->>Editor: produce HTML string (e.g. "<p><br></p>")
    Editor->>Norm: onChange -> pass HTML
    Norm-->>Editor: return "" or original HTML
    Editor->>Formik: setFieldValue(normalizedValue)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I nibbled tags in the editor light,
Trimmed tiny <p><br></p> out of sight,
"Empty no more!" the field did sing,
Now forms are tidy — hop, spring! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: introducing a utility to normalize empty Jodit HTML strings to actual empty strings for validation purposes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ghost]

Rebase based on master performed on branch and changes force pushed.

[smarcet]

@niko-exo seems that comment got truncated
let move this to an util method and lets take care of following corner cases
const normalizeJoditEmpty = (html) => { if (!html) return ""; const v = html.trim(); return (v === "<p><br></p>" || v === "<p><br/></p>" || v === "<p>&nbsp;</p>" || v === "<p></p>") ? "" : html; };

[ghost]

@smarcet Checkout the new implementation I've done. Seems to cover all cases you mentioned and more.

[smarcet]

LGTM