Skip to content

feat: show admin figma-ux correlation fixes #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 3 commits into from
Apr 22, 2026
Merged

feat: show admin figma-ux correlation fixes #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8880315
feat: show admin figma-ux correlation fixes
priscila-moneo Mar 18, 2026
470bc19
fix: replace mui-table, mui-table-editable and mui-table-sortable wit…
priscila-moneo Apr 9, 2026
396320b
fix: feedback from PR
priscila-moneo Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"moment": "^2.29.1",
"moment-duration-format": "^2.3.2",
"moment-timezone": "^0.5.33",
"openstack-uicore-foundation": "5.0.8",
"openstack-uicore-foundation": "5.0.9",
"p-limit": "^6.1.0",
"path-browserify": "^1.0.1",
"postcss-loader": "^6.2.1",
Expand Down
2 changes: 1 addition & 1 deletion src/actions/sponsor-forms-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const getSponsorForms =
const params = {
page: currentPage,
fields:
"id,code,name,level,expire_date,is_archived,sponsorship_types,apply_to_all_types",
"id,code,name,level,expire_date,is_archived,sponsorship_types,apply_to_all_types,opens_at,expires_at",

@martinquiroga-exo martinquiroga-exo Apr 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful here, we are changing the API contract, I assume new fields are already in the payload, let's double check since we can see we also have expore_date

@priscila-moneo priscila-moneo Apr 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far I could check, the field expire_date is currently requested from the API but is not used or displayed in the UI. No impact on the user interface at this time. For this PR I've added opens_at and expires_at that are available from the API and being used.

relations: "items,sponsorship_types",
per_page: perPage,
access_token: accessToken,
Expand Down
367 changes: 0 additions & 367 deletions src/components/mui/__tests__/mui-table-editable.test.js
View file
Open in desktop

This file was deleted.

Loading
Loading