Skip to content

fix: add popup to manual scan badge on sponsor badge scans tab #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 8 commits into from
Apr 22, 2026
Merged

fix: add popup to manual scan badge on sponsor badge scans tab #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a1a717
fix: add popup to manual scan badge on sponsor badge scans tab
tomrndom Mar 20, 2026
3c12db3
fix: disable button on submit, adjust actions, fix bug with question …
tomrndom Mar 26, 2026
27e365a
fix: add radio button, allow to set attendee or qr scan code
tomrndom Apr 14, 2026
e6b3cc8
fix: add unit test file for comoponent
tomrndom Apr 14, 2026
d407efb
fix: adjust imports paths on sponsor badge scans
tomrndom Apr 21, 2026
6bb2bda
fix: adjust mock for snackbar message
tomrndom Apr 21, 2026
19491a2
fix: update uicore version
tomrndom Apr 21, 2026
4c16b9f
Merge branch 'master' into fix/sponsor-badge-scan-manual
smarcet Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ EMAIL_SCOPES="clients/read templates/read templates/write emails/read"
FILE_UPLOAD_SCOPES="files/upload"
SPONSOR_PAGES_API_URL=https://sponsor-pages-api.dev.fnopen.com
SPONSOR_PAGES_SCOPES="page-template/read page-template/write show-page/read show-page/write media-upload/read"
SCOPES="profile openid offline_access reports/all ${EMAIL_SCOPES} ${INVENTORY_API_SCOPES} ${FILE_UPLOAD_SCOPES} ${PURCHASES_API_SCOPES} ${SPONSOR_USERS_SCOPES} ${SPONSOR_PAGES_SCOPES} ${DROPBOX_MATERIALIZER_API_SCOPES} ${SCOPES_BASE_REALM}/summits/delete-event ${SCOPES_BASE_REALM}/companies/read ${SCOPES_BASE_REALM}/companies/write ${SCOPES_BASE_REALM}/summits/write ${SCOPES_BASE_REALM}/summits/write-event ${SCOPES_BASE_REALM}/summits/read/all ${SCOPES_BASE_REALM}/summits/read ${SCOPES_BASE_REALM}/summits/publish-event ${SCOPES_BASE_REALM}/members/read ${SCOPES_BASE_REALM}/members/read/me ${SCOPES_BASE_REALM}/speakers/write ${SCOPES_BASE_REALM}/attendees/write ${SCOPES_BASE_REALM}/members/write ${SCOPES_BASE_REALM}/organizations/write ${SCOPES_BASE_REALM}/organizations/read ${SCOPES_BASE_REALM}/summits/write-presentation-materials ${SCOPES_BASE_REALM}/summits/registration-orders/update ${SCOPES_BASE_REALM}/summits/registration-orders/delete ${SCOPES_BASE_REALM}/summits/registration-orders/create/offline ${SCOPES_BASE_REALM}/summits/badge-scans/read config-values/write ${SCOPES_BASE_REALM}/summit-administrator-groups/read ${SCOPES_BASE_REALM}/summit-administrator-groups/write ${SCOPES_BASE_REALM}/summit-media-file-types/read ${SCOPES_BASE_REALM}/summit-media-file-types/write user-roles/write entity-updates/publish ${SCOPES_BASE_REALM}/audit-logs/read filter-criteria/read filter-criteria/write"
SCOPES="profile openid offline_access reports/all ${EMAIL_SCOPES} ${INVENTORY_API_SCOPES} ${FILE_UPLOAD_SCOPES} ${PURCHASES_API_SCOPES} ${SPONSOR_USERS_SCOPES} ${SPONSOR_PAGES_SCOPES} ${DROPBOX_MATERIALIZER_API_SCOPES} ${SCOPES_BASE_REALM}/summits/delete-event ${SCOPES_BASE_REALM}/companies/read ${SCOPES_BASE_REALM}/companies/write ${SCOPES_BASE_REALM}/summits/write ${SCOPES_BASE_REALM}/summits/write-event ${SCOPES_BASE_REALM}/summits/read/all ${SCOPES_BASE_REALM}/summits/read ${SCOPES_BASE_REALM}/summits/publish-event ${SCOPES_BASE_REALM}/members/read ${SCOPES_BASE_REALM}/members/read/me ${SCOPES_BASE_REALM}/speakers/write ${SCOPES_BASE_REALM}/attendees/write ${SCOPES_BASE_REALM}/members/write ${SCOPES_BASE_REALM}/organizations/write ${SCOPES_BASE_REALM}/organizations/read ${SCOPES_BASE_REALM}/summits/write-presentation-materials ${SCOPES_BASE_REALM}/summits/registration-orders/update ${SCOPES_BASE_REALM}/summits/registration-orders/delete ${SCOPES_BASE_REALM}/summits/registration-orders/create/offline ${SCOPES_BASE_REALM}/summits/badge-scans/read ${SCOPES_BASE_REALM}/summits/badge-scans/write config-values/write ${SCOPES_BASE_REALM}/summit-administrator-groups/read ${SCOPES_BASE_REALM}/summit-administrator-groups/write ${SCOPES_BASE_REALM}/summit-media-file-types/read ${SCOPES_BASE_REALM}/summit-media-file-types/write user-roles/write entity-updates/publish ${SCOPES_BASE_REALM}/audit-logs/read filter-criteria/read filter-criteria/write"
GOOGLE_API_KEY=
ALLOWED_USER_GROUPS="super-admins administrators summit-front-end-administrators summit-room-administrators track-chairs-admins sponsors"
APP_CLIENT_NAME="openstack"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"moment": "^2.29.1",
"moment-duration-format": "^2.3.2",
"moment-timezone": "^0.5.33",
"openstack-uicore-foundation": "5.0.12",
"openstack-uicore-foundation": "5.0.13",
"p-limit": "^6.1.0",
"path-browserify": "^1.0.1",
"postcss-loader": "^6.2.1",
Expand Down
26 changes: 26 additions & 0 deletions src/actions/attendee-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,3 +809,29 @@ export const queryPaidAttendees = _.debounce(
},
DEBOUNCE_WAIT
);

export const queryAttendees = _.debounce(async (input, summitId, callback) => {
const accessToken = await getAccessTokenSafely();

const endpoint = URI(
`${window.API_BASE_URL}/api/v1/summits/${summitId}/attendees`
);

input = escapeFilterValue(input);
endpoint.addQuery("access_token", accessToken);
endpoint.addQuery("order", "first_name,last_name");
endpoint.addQuery("page", 1);
endpoint.addQuery("per_page", DEFAULT_PER_PAGE);

if (input) {
endpoint.addQuery("filter[]", `full_name=@${input},email=@${input}`);
}

fetch(endpoint)
.then(fetchResponseHandler)
.then((json) => {
const options = [...json.data];
callback(options);
})
.catch(fetchErrorHandler);
}, DEBOUNCE_WAIT);
209 changes: 123 additions & 86 deletions src/actions/sponsor-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export const REQUEST_BADGE_SCANS = "REQUEST_BADGE_SCANS";
export const RECEIVE_BADGE_SCANS = "RECEIVE_BADGE_SCANS";
export const RECEIVE_BADGE_SCAN = "RECEIVE_BADGE_SCAN";
export const BADGE_SCAN_UPDATED = "BADGE_SCAN_UPDATED";
export const BADGE_SCAN_ADDED = "BADGE_SCAN_ADDED";
export const RESET_BADGE_SCAN_FORM = "RESET_BADGE_SCAN_FORM";
export const RECEIVE_SPONSORS_WITH_SCANS = "RECEIVE_SPONSORS_WITH_SCANS";

Expand Down Expand Up @@ -308,7 +309,7 @@ export const getSponsor = (sponsorId) => async (dispatch, getState) => {
const params = {
access_token: accessToken,
expand:
"company,members,sponsorships,sponsorships.type,featured_event,extra_questions,lead_report_setting",
"company,members,sponsorships,sponsorships.type,featured_event,extra_questions,extra_questions.values,lead_report_setting",
fields:
"featured_event.id,featured_event.title,sponsorships.id,sponsorships.type.id,sponsorships.type.type_id"
};
Expand Down Expand Up @@ -343,15 +344,16 @@ export const addSponsorToSummit = (entity) => async (dispatch, getState) => {
normalizedEntity,
snackbarErrorHandler,
entity
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("sponsor_list.sponsor_added")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("sponsor_list.sponsor_added")
})
);
})
.finally(() => dispatch(stopLoading()));
};

export const getSponsorTiers =
Expand Down Expand Up @@ -418,15 +420,16 @@ export const addTierToSponsor =
normalizedSponsorships,
snackbarErrorHandler,
sponsorships
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_sponsor.sponsorship_added")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_sponsor.sponsorship_added")
})
);
})
.finally(() => dispatch(stopLoading()));
};

export const removeTierFromSponsor =
Expand All @@ -450,15 +453,16 @@ export const removeTierFromSponsor =
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/sponsors/${sponsorId}/sponsorships/${sponsorshipId}`,
null,
snackbarErrorHandler
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_sponsor.sponsorship_removed")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_sponsor.sponsorship_removed")
})
);
})
.finally(() => dispatch(stopLoading()));
};

const normalizeSponsorToAdd = (entity) => {
Expand Down Expand Up @@ -595,15 +599,16 @@ export const removeAddonToSponsorship =
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/sponsors/${sponsorId}/sponsorships/${sponsorshipId}/add-ons/${addonId}`,
null,
snackbarErrorHandler
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_sponsor.sponsorship_addon_removed")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_sponsor.sponsorship_addon_removed")
})
);
})
.finally(() => dispatch(stopLoading()));
};

const normalizeAddons = (entity) => {
Expand Down Expand Up @@ -860,15 +865,16 @@ export const deleteExtraQuestion =
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/sponsors/${sponsorId}/extra-questions/${questionId}`,
null,
snackbarErrorHandler
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.done"),
html: T.translate("edit_sponsor.extra_question_deleted")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.done"),
html: T.translate("edit_sponsor.extra_question_deleted")
})
);
})
.finally(() => dispatch(stopLoading()));
};

export const saveSponsorExtraQuestion =
Expand Down Expand Up @@ -904,15 +910,16 @@ export const saveSponsorExtraQuestion =
normalizedEntity,
snackbarErrorHandler,
entity
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.done"),
html: T.translate("edit_sponsor.extra_question_saved")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.done"),
html: T.translate("edit_sponsor.extra_question_saved")
})
);
})
.finally(() => dispatch(stopLoading()));
}

return postRequest(
Expand All @@ -922,16 +929,17 @@ export const saveSponsorExtraQuestion =
normalizedEntity,
snackbarErrorHandler,
entity
)(params)(dispatch).then(({ response }) => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.done"),
html: T.translate("edit_sponsor.extra_question_created")
})
);
return response;
});
)(params)(dispatch)
.then(({ response }) => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.done"),
html: T.translate("edit_sponsor.extra_question_created")
})
);
return response;
})
.finally(() => dispatch(stopLoading()));
};

export const getSponsorExtraQuestion =
Expand Down Expand Up @@ -1266,15 +1274,16 @@ export const deleteSummitSponsorship =
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/sponsorships-types/${sponsorshipId}`,
null,
snackbarErrorHandler
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("summit_sponsorship_list.tier_deleted")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("summit_sponsorship_list.tier_deleted")
})
);
})
.finally(() => dispatch(stopLoading()));
};

const normalizeSponsorship = (entity) => {
Expand Down Expand Up @@ -1436,9 +1445,7 @@ export const getBadgeScan = (scanId) => async (dispatch, getState) => {
createAction(RECEIVE_BADGE_SCAN),
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/badge-scans/${scanId}`,
authErrorHandler
)(params)(dispatch).then(() => {
dispatch(stopLoading());
});
)(params)(dispatch).finally(() => dispatch(stopLoading()));
};

export const saveBadgeScan = (entity) => async (dispatch, getState) => {
Expand All @@ -1461,15 +1468,45 @@ export const saveBadgeScan = (entity) => async (dispatch, getState) => {
normalizedEntity,
snackbarErrorHandler,
entity
)(params)(dispatch).then(() => {
dispatch(stopLoading());
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_badge_scan.badge_scan_saved")
})
);
});
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_badge_scan.badge_scan_saved")
})
);
})
.finally(() => dispatch(stopLoading()));
};

export const addBadgeScan = (entity) => async (dispatch, getState) => {
const { currentSummitState } = getState();
const accessToken = await getAccessTokenSafely();
const { currentSummit } = currentSummitState;

dispatch(startLoading());

const params = {
access_token: accessToken
};

return postRequest(
null,
createAction(BADGE_SCAN_ADDED),
`${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/badge-scans`,
entity,
snackbarErrorHandler
)(params)(dispatch)
.then(() => {
dispatch(
snackbarSuccessHandler({
title: T.translate("general.success"),
html: T.translate("edit_badge_scan.badge_scan_saved")
})
);
})
.finally(() => dispatch(stopLoading()));
};
Comment on lines +1483 to +1510

@coderabbitai coderabbitai Bot Mar 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Inject the active sponsor before posting a new badge scan.

src/components/mui/mui-qr-badge-popup.js (Lines 64-68) submits only qr_code, scan_date, notes, and extra_questions, and this thunk forwards that payload unchanged to the summit-level /badge-scans endpoint. Because the sponsor is not part of the URL, admin-created scans are not explicitly tied to the sponsor whose badge-scans tab is open.

💡 Suggested fix 
 export const addBadgeScan = (entity) => async (dispatch, getState) => {
-  const { currentSummitState } = getState();
+  const { currentSummitState, currentSponsorState } = getState();
   const accessToken = await getAccessTokenSafely();
   const { currentSummit } = currentSummitState;
+  const sponsorId = currentSponsorState?.entity?.id;
 
   dispatch(startLoading());
 
   const params = {
     access_token: accessToken
   };
 
   return postRequest(
     null,
     createAction(BADGE_SCAN_ADDED),
     `${window.API_BASE_URL}/api/v1/summits/${currentSummit.id}/badge-scans`,
-    entity,
+    { ...entity, sponsor_id: sponsorId },
     snackbarErrorHandler
   )(params)(dispatch).then(() => {
     dispatch(stopLoading());
     dispatch(
       snackbarSuccessHandler({
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/actions/sponsor-actions.js` around lines 1476 - 1502, In addBadgeScan,
read the active sponsor from the Redux state (e.g., from
currentSponsorState.activeSponsor or selectedSponsor returned by getState()) and
inject it into the payload before calling postRequest (for example add
sponsor_id: activeSponsor.id or sponsor: activeSponsor as required by the API),
then pass the new payload (not the original entity) into postRequest; also
handle the case where no active sponsor is present (no-op or early return/error)
to avoid sending an un-scoped summit-level badge scan.


export const resetBadgeScanForm = () => (dispatch) => {
Expand Down
Loading
Loading