forked from OpenStackweb/summit-admin
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: move admin access group grid to mui #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
priscila-moneo
wants to merge
2
commits into
master
Choose a base branch
from
feature/move-admin-access-group-grid-mui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| /** | ||
| * @jest-environment jsdom | ||
| */ | ||
| import configureStore from "redux-mock-store"; | ||
| import thunk from "redux-thunk"; | ||
| import flushPromises from "flush-promises"; | ||
| import { | ||
| postRequest, | ||
| putRequest | ||
| } from "openstack-uicore-foundation/lib/utils/actions"; | ||
| import { saveAdminAccess } from "../admin-access-actions"; | ||
| import * as methods from "../../utils/methods"; | ||
|
|
||
| jest.mock("openstack-uicore-foundation/lib/utils/actions", () => ({ | ||
| __esModule: true, | ||
| ...jest.requireActual("openstack-uicore-foundation/lib/utils/actions"), | ||
| postRequest: jest.fn(), | ||
| putRequest: jest.fn() | ||
| })); | ||
|
|
||
| const requestMock = | ||
| (requestActionCreator, receiveActionCreator) => () => (dispatch) => { | ||
| if (requestActionCreator && typeof requestActionCreator === "function") { | ||
| dispatch(requestActionCreator({})); | ||
| } | ||
| return new Promise((resolve) => { | ||
| if (typeof receiveActionCreator === "function") { | ||
| dispatch(receiveActionCreator({ response: { id: 1 } })); | ||
| } else { | ||
| dispatch(receiveActionCreator); | ||
| } | ||
| resolve({ response: { id: 1 } }); | ||
| }); | ||
| }; | ||
|
|
||
| const rejectMock = () => () => () => Promise.reject(new Error("API error")); | ||
|
|
||
| describe("saveAdminAccess", () => { | ||
| const middlewares = [thunk]; | ||
| const mockStore = configureStore(middlewares); | ||
|
|
||
| beforeEach(() => { | ||
| jest.spyOn(methods, "getAccessTokenSafely").mockResolvedValue("TOKEN"); | ||
| postRequest.mockImplementation(requestMock); | ||
| putRequest.mockImplementation(requestMock); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.restoreAllMocks(); | ||
| }); | ||
|
|
||
| describe("create path (entity has no id)", () => { | ||
| it("returns a Promise", async () => { | ||
| const store = mockStore({}); | ||
| const result = store.dispatch( | ||
| saveAdminAccess({ title: "Group A", members: [], summits: [] }) | ||
| ); | ||
| expect(result).toBeInstanceOf(Promise); | ||
| await expect(result).resolves.toBeUndefined(); | ||
| }); | ||
|
|
||
| it("dispatches ADMIN_ACCESS_ADDED then STOP_LOADING on success", async () => { | ||
| const store = mockStore({}); | ||
| store.dispatch( | ||
| saveAdminAccess({ title: "Group A", members: [], summits: [] }) | ||
| ); | ||
| await flushPromises(); | ||
|
|
||
| const actionTypes = store.getActions().map((a) => a.type); | ||
| expect(actionTypes).toContain("ADMIN_ACCESS_ADDED"); | ||
| expect(actionTypes).toContain("STOP_LOADING"); | ||
| expect(actionTypes.indexOf("STOP_LOADING")).toBeGreaterThan( | ||
| actionTypes.indexOf("ADMIN_ACCESS_ADDED") | ||
| ); | ||
| }); | ||
|
|
||
| it("still dispatches STOP_LOADING when postRequest rejects", async () => { | ||
| postRequest.mockImplementation(rejectMock); | ||
| const store = mockStore({}); | ||
| await store | ||
| .dispatch( | ||
| saveAdminAccess({ title: "Group A", members: [], summits: [] }) | ||
| ) | ||
| .catch(() => {}); | ||
| await flushPromises(); | ||
|
|
||
| const actionTypes = store.getActions().map((a) => a.type); | ||
| expect(actionTypes).toContain("STOP_LOADING"); | ||
| }); | ||
| }); | ||
|
|
||
| describe("update path (entity has id)", () => { | ||
| it("returns a Promise", async () => { | ||
| const store = mockStore({}); | ||
| const result = store.dispatch( | ||
| saveAdminAccess({ id: 1, title: "Group A", members: [], summits: [] }) | ||
| ); | ||
| expect(result).toBeInstanceOf(Promise); | ||
| await expect(result).resolves.toBeUndefined(); | ||
| }); | ||
|
|
||
| it("dispatches ADMIN_ACCESS_UPDATED then STOP_LOADING on success", async () => { | ||
| const store = mockStore({}); | ||
| store.dispatch( | ||
| saveAdminAccess({ id: 1, title: "Group A", members: [], summits: [] }) | ||
| ); | ||
| await flushPromises(); | ||
|
|
||
| const actionTypes = store.getActions().map((a) => a.type); | ||
| expect(actionTypes).toContain("ADMIN_ACCESS_UPDATED"); | ||
| expect(actionTypes).toContain("STOP_LOADING"); | ||
| expect(actionTypes.indexOf("STOP_LOADING")).toBeGreaterThan( | ||
| actionTypes.indexOf("ADMIN_ACCESS_UPDATED") | ||
| ); | ||
| }); | ||
|
|
||
| it("still dispatches STOP_LOADING when putRequest rejects", async () => { | ||
| putRequest.mockImplementation(rejectMock); | ||
| const store = mockStore({}); | ||
| await store | ||
| .dispatch( | ||
| saveAdminAccess({ id: 1, title: "Group A", members: [], summits: [] }) | ||
| ) | ||
| .catch(() => {}); | ||
| await flushPromises(); | ||
|
|
||
| const actionTypes = store.getActions().map((a) => a.type); | ||
| expect(actionTypes).toContain("STOP_LOADING"); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.