Skip to content

fix: bug fixed in uicore beta version #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 1 commit into from
May 5, 2026
Merged

fix: bug fixed in uicore beta version #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"moment": "^2.29.1",
"moment-duration-format": "^2.3.2",
"moment-timezone": "^0.5.33",
"openstack-uicore-foundation": "5.0.16",
"openstack-uicore-foundation": "5.0.18-beta.1",

@coderabbitai coderabbitai Bot May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) Current manifest entry:"
rg -n '"openstack-uicore-foundation"' package.json

echo
echo "2) Lockfile resolution (if present):"
fd -HI 'yarn.lock|package-lock.json|pnpm-lock.yaml' .
for f in $(fd -HI 'yarn.lock|package-lock.json|pnpm-lock.yaml' .); do
  echo "--- $f ---"
  rg -n 'openstack-uicore-foundation|5\.0\.18-beta\.1' "$f" || true
done

echo
echo "3) Package metadata from npm (version, dist-tags, peer deps):"
npm view openstack-uicore-foundation@5.0.18-beta.1 version dist-tags peerDependencies --json

echo
echo "4) Find usage surface in repo (for targeted smoke checks by owner):"
rg -n --type=js --type=jsx 'openstack-uicore-foundation|from\s+["'\'']openstack-uicore-foundation["'\'']|require\(["'\'']openstack-uicore-foundation["'\'']\)'

Repository: fntechgit/summit-admin

Length of output: 2359

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Checking project's React version ==="
rg -n '"react"' package.json | head -20

echo
echo "=== Checking all dependencies with 'react' in name ==="
rg -n '"@?react' package.json | grep -E '"\s*@?react[^"]*"' || true

echo
echo "=== Full dependencies and devDependencies sections ==="
sed -n '/"dependencies":/,/"devDependencies":/p' package.json | head -50

Repository: fntechgit/summit-admin

Length of output: 2991

Peer dependency mismatch: This beta package requires React 17, but the project uses React 16

Line 95 upgrades openstack-uicore-foundation to 5.0.18-beta.1, which declares react: ^17.0.0 as a peer dependency. The project currently runs React 16.13.1. This incompatibility will cause runtime failures or undefined behavior. Either downgrade to the stable release (5.0.16), upgrade the project to React 17+, or provide evidence that the mismatch has been tested and handled.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 95, The package.json change upgrades
openstack-uicore-foundation to 5.0.18-beta.1 which declares react:^17.0.0 as a
peer dependency, but the project uses react 16.13.1; to fix, revert the
dependency to a compatible stable version (e.g., set
"openstack-uicore-foundation" back to "5.0.16"), or alternatively upgrade the
project's React to 17+ across package.json and lockfile and run full test/QA to
validate compatibility; ensure any CI or install scripts reflect the chosen
resolution and update README or changelog to document the decision.

"p-limit": "^6.1.0",
"path-browserify": "^1.0.1",
"postcss-loader": "^6.2.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8844,10 +8844,10 @@ open@^10.0.3:
is-inside-container "^1.0.0"
wsl-utils "^0.1.0"

openstack-uicore-foundation@5.0.16:
version "5.0.16"
resolved "https://registry.yarnpkg.com/openstack-uicore-foundation/-/openstack-uicore-foundation-5.0.16.tgz#5b7a8b79e926769b98bd2449633da8cf94bc78e8"
integrity sha512-33juij1pykdjspMQzEwGpWcgre7pP4RQc+ZYlSuMafG3Vv7ydaSJyC5Y8EVkHQx2RQeJqmL4P9v3bSe1mHg2CA==
openstack-uicore-foundation@5.0.18-beta.1:
version "5.0.18-beta.1"
resolved "https://registry.yarnpkg.com/openstack-uicore-foundation/-/openstack-uicore-foundation-5.0.18-beta.1.tgz#f79763d84cbe555c5401e254dbd756675bb52043"
integrity sha512-szrIkY99ljJwowsd3jsbmnOTd7hq3SeOTKCB2FFWu06hQ1FdRwX+vew6uqMTiXrIZt+DJlLaUXnd/bQaXCLqeg==

optionator@^0.9.1:
version "0.9.4"
Expand Down
Loading