Skip to content

fix: remove description validation from inventory and form items #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 1 commit into from
May 26, 2026
Merged

fix: remove description validation from inventory and form items #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ import {
nullableDecimalValidation,
requiredStringValidation,
positiveNumberValidation,
formMetafieldsValidation,
requiredHTMLValidation
formMetafieldsValidation
} from "../../../utils/yup";
import ItemPriceTiers from "../../../components/mui/formik-inputs/item-price-tiers";
import MuiFormikQuantityField from "../../../components/mui/formik-inputs/mui-formik-quantity-field";
Expand All @@ -57,7 +56,6 @@ const SponsorItemDialog = ({
validationSchema: yup.object().shape({
code: requiredStringValidation(),
name: requiredStringValidation(),
description: requiredHTMLValidation(),
images: yup.array(),
early_bird_rate: nullableDecimalValidation(),
standard_rate: nullableDecimalValidation(),
Expand Down Expand Up @@ -140,7 +138,7 @@ const SponsorItemDialog = ({
<Grid2 container spacing={2} size={12} sx={{ p: 3 }}>
<Grid2 size={12}>
<InputLabel htmlFor="description">
{T.translate("edit_inventory_item.description")} *
{T.translate("edit_inventory_item.description")}
</InputLabel>
<FormikTextEditor
name="description"
Expand Down
8 changes: 2 additions & 6 deletions src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,14 @@ import {
nullableDecimalValidation,
formMetafieldsValidation,
positiveNumberValidation,
requiredHTMLValidation,
requiredStringValidation
} from "../../../../utils/yup";
import MuiFormikTextField from "../../../../components/mui/formik-inputs/mui-formik-textfield";
import useScrollToError from "../../../../hooks/useScrollToError";
import ItemPriceTiers from "../../../../components/mui/formik-inputs/item-price-tiers";
import FormikTextEditor from "../../../../components/inputs/formik-text-editor";
import MuiFormikQuantityField from "../../../../components/mui/formik-inputs/mui-formik-quantity-field";
import {
MAX_INVENTORY_IMAGES_UPLOAD_QTY
} from "../../../../utils/constants";
import { MAX_INVENTORY_IMAGES_UPLOAD_QTY } from "../../../../utils/constants";
import { getFileUploadAllowedExtensions } from "../../../../utils/methods";

const buildInitialValues = (data) => ({ ...data });
Expand All @@ -43,7 +40,6 @@ const SponsorFormItemForm = ({ initialValues, onSubmit }) => {
validationSchema: yup.object({
code: requiredStringValidation(),
name: requiredStringValidation(),
description: requiredHTMLValidation(),
early_bird_rate: nullableDecimalValidation(),
standard_rate: nullableDecimalValidation(),
onsite_rate: nullableDecimalValidation(),
Expand Down Expand Up @@ -89,7 +85,7 @@ const SponsorFormItemForm = ({ initialValues, onSubmit }) => {
</Grid2>
<Grid2 size={12}>
<InputLabel htmlFor="description">
{T.translate("sponsor_form_item_list.edit_item.description")} *
{T.translate("sponsor_form_item_list.edit_item.description")}
</InputLabel>
<FormikTextEditor
name="description"
Expand Down
Loading