Skip to content

feat(events): add draft state banner and Save as Incomplete flow for presentations only#986

Merged
romanetar merged 1 commit into
masterfrom
feat/draft-state-banner
Jun 17, 2026
Merged

feat(events): add draft state banner and Save as Incomplete flow for presentations only#986
romanetar merged 1 commit into
masterfrom
feat/draft-state-banner

Conversation

@romanetar

@romanetar romanetar commented Jun 17, 2026

Copy link
Copy Markdown

ref https://app.clickup.com/t/86ba3xg57

Summary by CodeRabbit

  • Bug Fixes
    • Draft field warnings now display only for Presentation events requiring completion.
    • The "Save as Incomplete" button visibility has been refined for Presentation event submissions.

@romanetar romanetar requested a review from smarcet June 17, 2026 13:19
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e1c089a9-3206-418d-b0cd-b1bebadbdfcc

📥 Commits

Reviewing files that changed from the base of the PR and between da7128b and 1b793a7.

📒 Files selected for processing (1)
  • src/components/forms/event-form.js

📝 Walkthrough

Walkthrough

EventForm gains an isPresentation() helper that checks entity.class_name === "Presentation". The missingDraftFields computation in render() and the "save as incomplete" warning button in the submit-actions area are now both conditional on that helper, suppressing them for all non-Presentation event types.

Changes

Presentation-only draft UI gating

Layer / File(s) Summary
isPresentation helper, draft fields, and save-incomplete button
src/components/forms/event-form.js
Adds isPresentation() instance method checking entity.class_name; missingDraftFields now returns an empty list unless isPresentation() is true; the save-as-incomplete button now renders only when isPresentation() is true and the event is neither new nor complete.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • fntechgit/summit-admin#968: Directly related — introduced the draft-state missing-fields banner and save-as-incomplete button flow that this PR now gates to Presentation events only.

Suggested reviewers

  • smarcet

Poem

🐇 A bunny hopped through the form one day,
And found the draft warning had gone astray —
It popped up for events of every kind!
Now "Presentation" keeps it well-confined.
Only the right type gets the caution shown,
The rest of the events may leap on their own! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding draft state banner and Save as Incomplete flow, both specifically for presentations only, which aligns with the actual modifications to the EventForm component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/draft-state-banner

Comment @coderabbitai help to get the list of available commands and usage tips.

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanetar romanetar merged commit 5825ee5 into master Jun 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants