Skip to content

fix: make sponsor cart discount col wider#988

Merged
smarcet merged 2 commits into
masterfrom
fix/make-discount-col-wider
Jun 23, 2026
Merged

fix: make sponsor cart discount col wider#988
smarcet merged 2 commits into
masterfrom
fix/make-discount-col-wider

Conversation

@santipalenque

@santipalenque santipalenque commented Jun 17, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/86baauk2u

Summary by CodeRabbit

  • Chores
    • Updated a core UI library dependency to the latest beta version (openstack-uicore-foundation from 5.0.34 to 5.0.35-beta.0).

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a205c18f-00d7-48f0-8df4-2add280b7f58

📥 Commits

Reviewing files that changed from the base of the PR and between f367c67 and 8c2ca8a.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The openstack-uicore-foundation dependency in package.json is bumped from the pinned release 5.0.34 to the beta pre-release 5.0.35-beta.0. No other files or configurations are modified.

Changes

Dependency Version Bump

Layer / File(s) Summary
openstack-uicore-foundation version bump
package.json
Updates openstack-uicore-foundation from 5.0.34 to 5.0.35-beta.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐇 A package was bumped, just one tiny line,
From .34 to beta, oh how divine!
The rabbit hopped quick through the diff so small,
One version, one change — the simplest of all.
nom nom goes the carrot, the PR is done! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes a UI layout fix for the sponsor cart discount column, but the actual change is only a dependency version bump of openstack-uicore-foundation, which is unrelated to the title's stated objective. Update the PR title to accurately reflect the dependency version bump change, or verify that the actual changes match the stated UI layout objective in the title.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/make-discount-col-wider

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 95: The openstack-uicore-foundation dependency was bumped to an
undocumented beta version 5.0.35-beta.0 from stable 5.0.34, but the
justification and actual changes are unclear. Investigate the npm registry or
the library's repository commit history to document what changes are included in
the beta version 5.0.35-beta.0. Verify that this version includes the sponsor
cart UI layout fixes mentioned in the PR objective, and confirm that the
loggedUserReducer import used in src/store.js remains compatible. Either provide
clear documentation of what changed in the beta version and why it's required
instead of the stable version, or revert to the stable 5.0.34 if the beta bump
was unintended. If the sponsor cart UI changes should be part of this PR, ensure
those code modifications are included in the commit.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8aa70a61-5c5c-4270-a608-bd4561d0c354

📥 Commits

Reviewing files that changed from the base of the PR and between e5181cb and f367c67.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Comment thread package.json Outdated
Comment thread package.json Outdated
"moment-duration-format": "^2.3.2",
"moment-timezone": "^0.5.33",
"openstack-uicore-foundation": "5.0.34",
"openstack-uicore-foundation": "5.0.35-beta.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santipalenque please update to final 5.0.35 many thanks

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santipalenque please review

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 69c52e5 into master Jun 23, 2026
9 checks passed
@santipalenque santipalenque deleted the fix/make-discount-col-wider branch June 25, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants