feat: move event category group edition to MUI#996
Conversation
Signed-off-by: Priscila Moneo <priscila_moneo@hotmail.com.ar>
Signed-off-by: Priscila Moneo <priscila_moneo@hotmail.com.ar>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| sx={{ mb: 1 }} | ||
| > | ||
| <Grid2 size="grow"> | ||
| <Autocomplete |
There was a problem hiding this comment.
why not use uicore MuiFormikAsyncAutocomplete ? I think this should be its own component either way. Also @smarcet do we really need this input to be an async select ? Seems to me that tracks are never too many and a normal select would suffice.
| sx={{ mb: 1 }} | ||
| > | ||
| <Grid2 size="grow"> | ||
| <Autocomplete |
There was a problem hiding this comment.
Same comment as for Track async select,. Should be at least its own component, but @smarcet pretty sure track groups cannot be more than a few dozens realistically
| onAllowedGroupLink, | ||
| onAllowedGroupUnLink | ||
| }) => { | ||
| const [isSaving, setIsSaving] = useState(false); |
| const [selectedTrack, setSelectedTrack] = useState(null); | ||
| const [trackPage, setTrackPage] = useState(1); | ||
| const [trackPerPage, setTrackPerPage] = useState(DEFAULT_PER_PAGE); | ||
| const [groupInput, setGroupInput] = useState(""); |
There was a problem hiding this comment.
can we at least group states by type ? for example :
const [trackState, setTrackState] = useState({input, options, selected, page, perPage})
| } | ||
| }; | ||
|
|
||
| const MuiFormikColorInput = ({ name, ...props }) => { |
priscila-moneo
force-pushed
the
feature/move-event-category-groups-mui
branch
from
2d543dc to
f9057ba
Compare
2 participants
ref: https://app.clickup.com/t/9014802374/86bagk9rk