'script' field is optional if 'options.command' is defined#73
Closed
piranna wants to merge 4 commits intoforeversd:masterfrom
Closed
'script' field is optional if 'options.command' is defined#73piranna wants to merge 4 commits intoforeversd:masterfrom
piranna wants to merge 4 commits intoforeversd:masterfrom
Conversation
Author
|
Tests are giving some random errors unrelated with this issue, in my machine with node v0.10.35 there's a "callback not fired" error in "When using forever-monitor attempting to start a script that doesn't exist", while in Travis that Node.js version works but it fails with Node.js 0.8 with a "log files should not be truncated" erron in "When using the logger plugin with custom log files and the append option set". |
Member
|
This was superceded by #70. |
Author
|
@indexzero, how it's supposed #70 superceded this? I've reviewed both codes and don't see any relationship with their purposses... |
Member
|
You are messing with logic that was heavily modified by #70. If you'd like to resubmit branched off master that'd be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an 'options.command' is set, this allow to don't put anything on the 'script' field of Monitor constructor, only the options bag. Also it has some clean-ups.