Pre-commit hook can't find node

[bmv437]

Hey there,

I'm using husky to run a pre-commit hook on my repo, and everything runs correctly in my terminal when I run
git commit -m "some message"

The issue is when I try and commit with Fork, and it attempts to run the pre-commit hook and fails because it can't find node. Here's the full error from Fork

Pre-commit hook 'pre-commit' has failed:
husky > npm run -s precommit (node )


husky > pre-commit hook failed (add --no-verify to bypass)

/Users/brandon/project/.git/hooks/pre-commit: line 49: node: command not found
env: node: No such file or directory

when I run which node I get
/Users/brandon/.nvf/installed/node-8.5.0/bin/node

Full disclosure I'm using macOS, with fish shell, and nvf to manage my node versions. I just really wonder how Fork is running the pre-commit in a way where it can't find my node installation. Let me know if you have any questions or need more info.

[DanPristupov]

It looks like Fork doesn't have node in PATH in ENV.
You can use absolute paths in your hook or you can run From from your terminal. In this way Fork will inherit PATH of the terminal and will be able to use same aliases.

[DanPristupov]

I suppose I can close this

[nicekiwi]

This is still an issue for me. When using Node Version manager, fork can't seem to find the npm executable.

[DanPristupov]

@nicekiwi did you try to start Fork from terminal as I mentioned in my comment?

Where is npm located in your system ($ which npm)?

[nicekiwi]

@DanPristupov yeah it does work starting form command line.

/Users/ezrasharp/.nvm/versions/node/v13.0.1/bin/npm

[marianhlavac]

You can use absolute paths in your hook or you can run From from your terminal.

Well, I understand that the problem isn't trivial, but this isn't much elegant solution for the problem.

• Using absolute paths in hooks will break them for other developers in team.
• Running Fork always from terminal seems to be counter-intuitive, I like to have Fork on my macOS dock or run it using Spotlight.

I'd understand this behaviour when using bundled Fork git instance, but the system git instance should be equivalent to typing git into my default shell.

[DanPristupov]

I'd understand this behaviour when using bundled Fork git instance, but the system git instance should be equivalent to typing git into my default shell.

No, things in OS don't work like that. In *nix (including BSD, including macOS) a process inherits environment of the parent process. The environment of your shell is available only for that shell process or the processes which it started. Fork (or any other process started from Dock or Spotlight) doesn't have an access to it.

[marianhlavac]

I understand how OS works and what process tree is, I was just stating what the end user would expect to happen when clicking commit in Fork, while using git hooks.

…

On 12 Nov 2020, at 18:34, Dan ***@***.***> wrote:  I'd understand this behaviour when using bundled Fork git instance, but the system git instance should be equivalent to typing git into my default shell. No, things in OS don't work like that. In *nix (including BSD, including macOS) a process inherits environment of the parent process. The environment of your shell is available only for that shell process or the processes which it started. Fork (or any other process started from Dock or Spotlight) doesn't have an access to it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[McFlyssss]

I'm facing a similar issue. Fork is using a different node version than my project so then when running the tests with hooks they do not pass (They crash because of the node version).

Any suggestion guys?

[DanPristupov]

@McFlyssss Start Fork from the terminal using open -a Fork command.

[Legys]

typicode/husky#390 (comment) This worked fine for me, none of the existing solutions didn't help. They just change nothing.

[svvitale]

You can also symbolic link your npm installation to one of the directories listed in /etc/paths OR add the necessary profile paths to that file. This avoids the need to start Fork from the terminal AND avoids modifying your pre-commit hooks.

[msgirlperl]

I always start fork from my terminal and it's still using the wrong version for me. Any other ideas? I tried open -a fork (I typically just type fork) but it still didn't work.

which npm yields:
/Users/mcrowley/.nvm/versions/node/v12.14.1/bin/npm for me.

Attempting to commit through fork gives:

husky > pre-commit (node v13.7.0)
warning Integrity check: System parameters don't match
error Integrity check failed
error Found 1 errors.
husky > pre-commit hook failed (add --no-verify to bypass)

Full disclosure: I'm not super familiar with macs.

[DanPristupov]

@msgirlperl
Try to add echo $PATH to the hook and run it from Fork. It will show what PATH is used.