Skip to content
This repository was archived by the owner on May 23, 2019. It is now read-only.

Fix zeroes not being displayed in formatted strings#112

Closed
rlivsey wants to merge 1 commit intoformatjs:masterfrom
rlivsey:fix-no-zeroes
Closed

Fix zeroes not being displayed in formatted strings#112
rlivsey wants to merge 1 commit intoformatjs:masterfrom
rlivsey:fix-no-zeroes

Conversation

@rlivsey
Copy link

@rlivsey rlivsey commented Sep 2, 2015

No description provided.

@redbugz
Copy link

redbugz commented Sep 15, 2015

👍 we have some places we display zero as well, so this will affect us as well.

@pgherveou
Copy link

I ran into this issue on our app too, can a new version be published on npm?

@jasonmit
Copy link
Collaborator

Ping @ericf @caridy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use {age, number} in something like this?

@rlivsey
Copy link
Author

rlivsey commented Nov 16, 2015

Closing as {foo, number} does the job, and {foo, plural … } renders zeroes fine when using #.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants