Skip to content
This repository was archived by the owner on May 23, 2019. It is now read-only.

IntlMessageFormat("{0}").format([0]) should be "0" not ""#119

Closed
ianhk wants to merge 1 commit intoformatjs:masterfrom
ianhk:master
Closed

IntlMessageFormat("{0}").format([0]) should be "0" not ""#119
ianhk wants to merge 1 commit intoformatjs:masterfrom
ianhk:master

Conversation

@ianhk
Copy link

@ianhk ianhk commented Nov 27, 2015

The number 0 is now formatted as "0" within message strings, previously is was formatted as "" (empty string).

@ianhk ianhk changed the title IntlMessageFormat("{n}").format(0) should be "0" not "" IntlMessageFormat("{0}").format([0]) should be "0" not "" Nov 27, 2015
@ericf
Copy link
Collaborator

ericf commented Mar 6, 2016

This PR has edited a dist file, not source. Also, this is intended, as you should use "{0, number}" if you want number formatting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants