This repository was archived by the owner on May 23, 2019. It is now read-only.
Fixed formatting of 0 number literal#136
Closed
JackieChiles wants to merge 1 commit intoformatjs:masterfrom
Closed
Fixed formatting of 0 number literal#136JackieChiles wants to merge 1 commit intoformatjs:masterfrom
JackieChiles wants to merge 1 commit intoformatjs:masterfrom
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
Author
|
@jasonmit This may be of interest to you. |
Collaborator
|
Use |
Author
|
@ericf True that will work, but |
Collaborator
|
Using I'm going to close this out as it's been brought up before and we decided against it. |
|
Echoing what I said here: formatjs/formatjs#711 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this issue when using ember-intl. With the following:
Template
{{t 'numItems' num=0}}Translation
"numItems": "There are ({num}) items"The rendered string was
There are () itemswhereas the expected output isThere are (0) items. This PR allows intl-messageformat to correctly render the literal0.