This repository was archived by the owner on May 23, 2019. It is now read-only.
fix: consuming using jsnext:main fails#138
Merged
jasonmit merged 1 commit intoformatjs:masterfrom Jul 10, 2017
Merged
Conversation
The export command is executed before the definition of defineProperty & objCreate so when consuming the src module using jsnext:main in webpack + babel, our build fails due to undefined defineProperty & objCreate. Moving the export to the bottom of the file solves the issue.
|
CLA is valid! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export command is executed before the definition of defineProperty & objCreate so when consuming the src module using jsnext:main in webpack + babel, our build fails due to undefined defineProperty & objCreate. Moving the export to the bottom of the file solves the issue.