Skip to content
This repository was archived by the owner on May 23, 2019. It is now read-only.

use Intl.PluralRules instead of packaging CLDR#185

Merged
longlho merged 3 commits intoformatjs:masterfrom
longlho:pluralrules
May 16, 2019
Merged

use Intl.PluralRules instead of packaging CLDR#185
longlho merged 3 commits intoformatjs:masterfrom
longlho:pluralrules

Conversation

@longlho
Copy link
Member

@longlho longlho commented May 16, 2019

fixes #172
also bumped major version since this is not backwards compat

@longlho longlho requested review from okuryu and redonkulus May 16, 2019 03:21
Copy link
Member

@redonkulus redonkulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to only require it if the native API is not available. Is that possible?

@longlho
Copy link
Member Author

longlho commented May 16, 2019

@redonkulus Intl.js polyfill already supports it (andyearnshaw/Intl.js#262) like 2 years ago, but for some reason hasn't been released.

The other polyfill is https://github.com/eemeli/intl-pluralrules

We can def package a polyfill with ourselves. I don't mind either way

@redonkulus
Copy link
Member

Could we just require the application to provide the polyfill instead of doing it here?

@okuryu
Copy link
Member

okuryu commented May 16, 2019

I hope Intl.js moves to FormatJS org to maintain parts.

@redonkulus
Copy link
Member

I hope Intl.js moves to FormatJS org to maintain parts.

Intl.js was meant to be a stop gap solution until JS runtimes supported Intl natively. I believe most, if not all, modern browsers and Node support it today. We should start considering the general availability of these APIs instead of continuing to bundle or rely on a polyfill.

@longlho longlho merged commit 8ac0408 into formatjs:master May 16, 2019
@longlho longlho deleted the pluralrules branch May 16, 2019 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Intl.PluralRules

3 participants