Allow drag and drop of effects on items#1766
Merged
Fyorl merged 3 commits intofoundryvtt:2.0.xfrom Sep 19, 2022
Merged
Conversation
Fyorl
requested changes
Sep 12, 2022
Contributor
Fyorl
left a comment
There was a problem hiding this comment.
Good stuff, thanks. Just some code style suggestions from me.
Co-authored-by: Kim Mantas <kim.mantas@gmail.com>
Collaborator
Author
|
changes made @Fyorl thanks for the suggestions :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces drag and drop handlers for the Item Sheet to allow Effects to be dragged and dropped between items.
This also allows effects to be drag and dropped from an item onto an actor to emulate applying the effect.
Use Cases:
Methodology
Copies what core does for dropping active effects on Actor Sheets, with one change:
originof the created effect to be theuuidof the new parent item.Research
I've been doing this with with the module: Drop Effects on Items for several months and it's been very useful.