forked from pester/Pester
-
Notifications
You must be signed in to change notification settings - Fork 0
Make Gherkin test runner behave more like Ruby's Cucumber #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fourpastmidnight
wants to merge
2
commits into
fix-#1124-pester-does-not-print-DocStrings-or-DataTables
from
skip-rest-of-scenario-steps-after-first-non-passing-step
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,18 @@ | ||
| Given "the following DocString:?" { | ||
| param([string]$DocString) | ||
|
|
||
| #throw | ||
| Set-StepPending | ||
| $DocString | Should -Not -BeNull | ||
| } | ||
|
|
||
| When "this scenario is run" { } | ||
| When "this scenario is run" { #Set-StepPending | ||
| } | ||
|
|
||
| Then "the DocString is displayed in the console" { } | ||
|
|
||
| GherkinStep "a (square|rectangular|single column) data table:?" { param($table) } | ||
| Then "the tables are displayed correctly in the console" { } | ||
|
|
||
| Given "a number '(\d+)' and a number '(\d+)" { param([int]$x, [int]$y) } | ||
| When "I add them together" { } | ||
| Then "I should get '(\d+)" { param([int]$result) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| function New-UndefinedStepErrorRecord ([string] $File, [string] $Line, [string] $LineText) { | ||
| $exception = New-Object Exception "No matching step definition found." | ||
| $errorID = 'PesterUndefinedGherkinStep' | ||
| $errorCategory = [Management.Automation.ErrorCategory]::InvalidResult | ||
| # we use ErrorRecord.TargetObject to pass structured information about the error to a reporting system. | ||
| $targetObject = @{Message = $Message; File = $File; Line = $Line; LineText = $LineText} | ||
| $errorRecord = New-Object Management.Automation.ErrorRecord $exception, $errorID, $errorCategory, $targetObject | ||
| return $errorRecord | ||
| } | ||
|
|
||
| function New-PendingStepErrorRecord ([string] $File, [string] $Line, [string] $LineText) { | ||
| $exception = New-Object Exception "# TODO: (Pester::Pending)" | ||
| $errorID = 'PesterPendingGherkinStep' | ||
| $errorCategory = [Management.Automation.ErrorCategory]::InvalidResult | ||
| # we use ErrorRecord.TargetObject to pass structured information about the error to a reporting system. | ||
| $targetObject = @{Message = $Message; File = $File; Line = $Line; LineText = $LineText} | ||
| $errorRecord = New-Object Management.Automation.ErrorRecord $exception, $errorID, $errorCategory, $targetObject | ||
| return $errorRecord | ||
| } | ||
|
|
||
| function Set-StepPending { | ||
| <# | ||
|
|
||
| .SYNOPSIS | ||
| Set-StepPending used inside Step Definition blocks will cause those steps to be | ||
| considered as pending. | ||
|
|
||
| .DESCRIPTION | ||
| If Set-StepPending is used inside a step definition block, the test will be | ||
| considered as Pending. It's not a passed result, nor a failed result, | ||
| but something in between. It indicates that the results of the test could not | ||
| be verified. A step definition with a Pending result will be considered as | ||
| Inconclusive when output to the NUnitXml report, unless overridden by | ||
| specifying pending and inconclusive tests as failed. | ||
|
|
||
| .EXAMPLE | ||
|
|
||
| Invoke-Gherkin | ||
|
|
||
| Given "this step is not yet implemented" { | ||
|
|
||
| Set-StepPending | ||
|
|
||
| } | ||
|
|
||
| The test result. | ||
|
|
||
| Scenario: Tests with steps using Set-StepPending are pending | ||
| [?] Given this step is not yet implemented 96ms | ||
| # TODO: (Pester::Pending) | ||
| at C:\Users\<SOME_FOLDER>\features\Example.Steps.ps1: line 10 | ||
| at C:\Users\<SOME_FOLDER>\features\MyNewFeature.feature: line 10 | ||
| [!] When something else 0ms | ||
| [!] Then this should happen 0ms | ||
|
|
||
| 1 scenario (1 pending) | ||
| 3 steps (2 skipped, 1 pending) | ||
| Tests completed in 408ms | ||
|
|
||
| #> | ||
| [CmdletBinding()] | ||
| param ( ) | ||
|
|
||
| Assert-DescribeInProgress -CommandName Set-StepPending | ||
| $lineText = $MyInvocation.Line.TrimEnd($([System.Environment]::NewLine)) | ||
| $line = $MyInvocation.ScriptLineNumber | ||
| $file = $MyInvocation.ScriptName | ||
|
|
||
| throw ( New-PendingStepErrorRecord -File $file -Line $line -LineText $lineText) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing this function and adding a
-Pendingparameter toGherkinStepinGherkin.ps1. See #1.