[Phase 1] Backend: NoneType error accessing search_pattern during task execution

[frankbria]

Problem

Task execution fails with AttributeError: 'NoneType' object has no attribute 'search_pattern' when processing certain tasks during E2E tests.

Error

AttributeError: 'NoneType' object has no attribute 'search_pattern'

Followed by:

[WebServer] No files to review for task 868
[WebServer] Task 869 failed: AttributeError: 'NoneType' object has no attribute 'search_pattern'
[WebServer] No files to review for task 869
[WebServer] Task 871 failed: AttributeError: 'NoneType' object has no attribute 'search_pattern'

Root Cause

Code attempts to access .search_pattern attribute on an object that is None. This likely occurs when:

1. A task's associated file pattern or search context is not initialized
2. A database lookup returns None but the code doesn't check before accessing attributes
3. Task metadata is incomplete from seeding

Affected Tasks

• Task 868, 869, 871 (and potentially others)

Location

Likely in one of:

• codeframe/agents/backend_worker_agent.py
• codeframe/agents/frontend_worker_agent.py
• codeframe/core/file_reviewer.py

Expected Behavior

When search_pattern or its parent object is None:

1. Log a warning
2. Skip the file review step gracefully
3. Continue task execution or fail with a clear error message

Suggested Fix

# Before
files = self.find_files(task.search_pattern)

# After
if task.search_pattern is None:
    logger.warning(f"Task {task.id} has no search_pattern, skipping file review")
    files = []
else:
    files = self.find_files(task.search_pattern)

Or use defensive access:

search_pattern = getattr(task, 'search_pattern', None)
if search_pattern:
    files = self.find_files(search_pattern)

Impact

• Multiple task execution failures
• Tasks retry 3 times then marked as failed
• Blocks agent execution workflow

Related

• [P1] FrontendWorkerAgent receives dict instead of Task object #251 - FrontendWorkerAgent receives dict instead of Task object (similar type/attribute issues)

[traycerai]

Plan

Observations

The issue occurs when BackendWorkerAgent.build_context() attempts to call self.codebase_index.search_pattern() but self.codebase_index is None. This happens because:

1. LeadAgent initializes AgentPoolManager without passing its codebase_index (file:codeframe/agents/lead_agent.py, lines 97-104)
2. AgentPoolManager defaults codebase_index=None (file:codeframe/agents/agent_pool_manager.py, line 83)
3. When creating BackendWorkerAgent, it passes None as codebase_index (file:codeframe/agents/agent_pool_manager.py, lines 500-505)
4. BackendWorkerAgent.build_context() already has a null-check at lines 242-254, but initialization warning is missing

Approach

Implement defensive programming with graceful degradation across all agent types. Phase 1 focuses on ensuring null-safety checks are in place and adding comprehensive logging for visibility. The existing null-check in BackendWorkerAgent.build_context() (lines 242-254) handles the core issue, but initialization warnings and audit of other agent types are needed. Phase 2 (future) will implement late-binding of codebase_index to AgentPoolManager after it's built.

Implementation Steps

1. Verify BackendWorkerAgent.build_context() Null-Safety

File: file:codeframe/agents/backend_worker_agent.py

Location: Method build_context() around line 242

Current State: Already has null-check at lines 242-254

Verification Action:

• Confirm the null-check exists and properly handles codebase_index=None
• Verify warning message is logged when index is None
• Ensure related_symbols and related_files are set to empty lists when index is None
• No code changes needed if check is already in place

Expected Code Pattern:

# Around line 242-254
if self.codebase_index is None:
    logger.warning(
        f"Task {task.get('id', 'unknown')} has no codebase_index, "
        "skipping symbol search"
    )
    related_symbols = []
    related_files = []
else:
    related_symbols = self.codebase_index.search_pattern(search_terms)
    related_files = list(set(symbol.file_path for symbol in related_symbols))

2. Add Initialization Warning in BackendWorkerAgent.init()

File: file:codeframe/agents/backend_worker_agent.py

Location: Method __init__() around line 83-84

Changes:

• After storing self.codebase_index, check if it's None
• Log a warning that context building will be limited
• This provides early visibility into configuration issues

Implementation:

# Around line 83-84
self.codebase_index = codebase_index

# Warn if codebase_index is not provided
if self.codebase_index is None:
    logger.warning(
        "BackendWorkerAgent initialized without codebase_index. "
        "Context building will be limited to task descriptions only."
    )

3. Add Logging to AgentPoolManager._create_traditional_agent()

File: file:codeframe/agents/agent_pool_manager.py

Location: Lines 500-505 in _create_traditional_agent() method

Changes:

• Add debug logging when creating BackendWorkerAgent with codebase_index=None
• Track when agents are created without index for debugging

Implementation:

# Around lines 500-505
if agent_type == "backend" or agent_type == "backend-worker":
    if self.codebase_index is None:
        logger.debug(
            f"Creating BackendWorkerAgent {agent_id} without codebase_index "
            "(will be available after index is built)"
        )
    return BackendWorkerAgent(
        db=self.db,
        codebase_index=self.codebase_index,
        provider="anthropic",
        api_key=self.api_key,
    )

4. Audit Other Agent Types for Similar Issues

Files to Check:

• file:codeframe/agents/frontend_worker_agent.py
• file:codeframe/agents/test_worker_agent.py
• file:codeframe/agents/review_worker_agent.py

Action:

• Search for any direct access to codebase_index attributes
• Add null-safety checks if found
• Pattern to search: self.codebase_index. without preceding null-check

5. Add Unit Tests for Null-Safety

File: file:tests/agents/test_backend_worker_agent.py

Changes:

• Add test case for BackendWorkerAgent with codebase_index=None
• Verify that build_context() returns empty related_symbols and related_files
• Verify warning is logged

Test Case:

def test_build_context_without_codebase_index():
    """Test that build_context handles missing codebase_index gracefully."""
    # Create agent with codebase_index=None
    agent = BackendWorkerAgent(
        db=mock_db,
        codebase_index=None,
        provider="anthropic",
        api_key="test-key"
    )
    
    # Create test task
    task = {
        "id": 1,
        "title": "Test Task",
        "description": "Test Description"
    }
    
    # Call build_context
    context = agent.build_context(task)
    
    # Assert related_symbols and related_files are empty
    assert context.get("related_symbols") == []
    assert context.get("related_files") == []

6. Add Integration Tests

File: file:tests/integration/test_agent_pool_manager.py

Changes:

• Add test case for agent pool creation without codebase_index
• Verify agents work correctly with None index

Test Case:

def test_agent_pool_without_codebase_index():
    """Test that agent pool works when codebase_index is None."""
    # Create pool without index
    pool = AgentPoolManager(
        project_id=1,
        db=mock_db,
        codebase_index=None
    )
    
    # Create backend agent
    agent_id = pool.create_agent("backend")
    agent = pool.get_agent_instance(agent_id)
    
    # Verify agent has None index
    assert agent.codebase_index is None
    
    # Verify agent can still be used
    task = {"id": 1, "title": "Test", "description": "Test"}
    context = agent.build_context(task)
    assert context is not None

7. Run E2E Tests to Verify Fix

Action:

• Execute E2E tests with tasks 868, 869, 871
• Confirm they no longer fail with NoneType error
• Verify warning logs appear for missing codebase_index

Expected Result:

• Tasks execute successfully
• Warnings logged about missing codebase_index
• No AttributeError exceptions

Impact Analysis

Affected Components:

• file:codeframe/agents/backend_worker_agent.py - Add initialization warning
• file:codeframe/agents/agent_pool_manager.py - Add debug logging
• file:codeframe/agents/frontend_worker_agent.py - Audit for null-safety
• file:codeframe/agents/test_worker_agent.py - Audit for null-safety
• file:codeframe/agents/review_worker_agent.py - Audit for null-safety
• Test files - Add unit and integration tests

Behavior Changes:

• Tasks execute successfully even without codebase index
• Context building gracefully degrades to task title/description only
• Warnings and debug logs for visibility into configuration state
• No breaking changes to existing functionality

Backward Compatibility:

• All changes are additive (new logging, new tests)
• Existing code paths remain unchanged
• Graceful degradation when index is unavailable

Testing Strategy

1. Unit Tests: Verify build_context() handles None codebase_index
2. Integration Tests: Verify agent pool creation and usage with None index
3. E2E Tests: Run existing E2E tests with problematic tasks (868, 869, 871)
4. Log Verification: Confirm warning and debug messages appear in logs

Success Criteria

• No AttributeError: 'NoneType' object has no attribute 'search_pattern' errors
• Tasks 868, 869, 871 execute successfully
• Warning logs appear when agents are created without codebase_index
• All new unit and integration tests pass
• Existing tests continue to pass
• Code review approved

Future Enhancements (Phase 2)

• Implement late-binding of codebase_index to AgentPoolManager after it's built
• Add set_codebase_index() method to AgentPoolManager
• Update LeadAgent.build_codebase_index() to call agent_pool_manager.set_codebase_index()
• Consider making codebase_index required or building it earlier in initialization

Import In IDE

🤖 Prompt for AI Agents

## Observations

The issue occurs when `BackendWorkerAgent.build_context()` attempts to call `self.codebase_index.search_pattern()` but `self.codebase_index` is `None`. This happens because:

1. `LeadAgent` initializes `AgentPoolManager` without passing its `codebase_index` (file:codeframe/agents/lead_agent.py, lines 97-104)
2. `AgentPoolManager` defaults `codebase_index=None` (file:codeframe/agents/agent_pool_manager.py, line 83)
3. When creating `BackendWorkerAgent`, it passes `None` as `codebase_index` (file:codeframe/agents/agent_pool_manager.py, lines 500-505)
4. `BackendWorkerAgent.build_context()` already has a null-check at lines 242-254, but initialization warning is missing

## Approach

Implement defensive programming with graceful degradation across all agent types. Phase 1 focuses on ensuring null-safety checks are in place and adding comprehensive logging for visibility. The existing null-check in `BackendWorkerAgent.build_context()` (lines 242-254) handles the core issue, but initialization warnings and audit of other agent types are needed. Phase 2 (future) will implement late-binding of `codebase_index` to `AgentPoolManager` after it's built.

## Implementation Steps

### 1. Verify BackendWorkerAgent.build_context() Null-Safety

**File:** `file:codeframe/agents/backend_worker_agent.py`

**Location:** Method `build_context()` around line 242

**Current State:** Already has null-check at lines 242-254

**Verification Action:**
- Confirm the null-check exists and properly handles `codebase_index=None`
- Verify warning message is logged when index is None
- Ensure `related_symbols` and `related_files` are set to empty lists when index is None
- No code changes needed if check is already in place

**Expected Code Pattern:**
```python
# Around line 242-254
if self.codebase_index is None:
    logger.warning(
        f"Task {task.get('id', 'unknown')} has no codebase_index, "
        "skipping symbol search"
    )
    related_symbols = []
    related_files = []
else:
    related_symbols = self.codebase_index.search_pattern(search_terms)
    related_files = list(set(symbol.file_path for symbol in related_symbols))
```

### 2. Add Initialization Warning in BackendWorkerAgent.__init__()

**File:** `file:codeframe/agents/backend_worker_agent.py`

**Location:** Method `__init__()` around line 83-84

**Changes:**
- After storing `self.codebase_index`, check if it's `None`
- Log a warning that context building will be limited
- This provides early visibility into configuration issues

**Implementation:**
```python
# Around line 83-84
self.codebase_index = codebase_index

# Warn if codebase_index is not provided
if self.codebase_index is None:
    logger.warning(
        "BackendWorkerAgent initialized without codebase_index. "
        "Context building will be limited to task descriptions only."
    )
```

### 3. Add Logging to AgentPoolManager._create_traditional_agent()

**File:** `file:codeframe/agents/agent_pool_manager.py`

**Location:** Lines 500-505 in `_create_traditional_agent()` method

**Changes:**
- Add debug logging when creating BackendWorkerAgent with `codebase_index=None`
- Track when agents are created without index for debugging

**Implementation:**
```python
# Around lines 500-505
if agent_type == "backend" or agent_type == "backend-worker":
    if self.codebase_index is None:
        logger.debug(
            f"Creating BackendWorkerAgent {agent_id} without codebase_index "
            "(will be available after index is built)"
        )
    return BackendWorkerAgent(
        db=self.db,
        codebase_index=self.codebase_index,
        provider="anthropic",
        api_key=self.api_key,
    )
```

### 4. Audit Other Agent Types for Similar Issues

**Files to Check:**
- `file:codeframe/agents/frontend_worker_agent.py`
- `file:codeframe/agents/test_worker_agent.py`
- `file:codeframe/agents/review_worker_agent.py`

**Action:**
- Search for any direct access to `codebase_index` attributes
- Add null-safety checks if found
- Pattern to search: `self.codebase_index.` without preceding null-check

### 5. Add Unit Tests for Null-Safety

**File:** `file:tests/agents/test_backend_worker_agent.py`

**Changes:**
- Add test case for `BackendWorkerAgent` with `codebase_index=None`
- Verify that `build_context()` returns empty `related_symbols` and `related_files`
- Verify warning is logged

**Test Case:**
```python
def test_build_context_without_codebase_index():
    """Test that build_context handles missing codebase_index gracefully."""
    # Create agent with codebase_index=None
    agent = BackendWorkerAgent(
        db=mock_db,
        codebase_index=None,
        provider="anthropic",
        api_key="test-key"
    )
    
    # Create test task
    task = {
        "id": 1,
        "title": "Test Task",
        "description": "Test Description"
    }
    
    # Call build_context
    context = agent.build_context(task)
    
    # Assert related_symbols and related_files are empty
    assert context.get("related_symbols") == []
    assert context.get("related_files") == []
```

### 6. Add Integration Tests

**File:** `file:tests/integration/test_agent_pool_manager.py`

**Changes:**
- Add test case for agent pool creation without codebase_index
- Verify agents work correctly with None index

**Test Case:**
```python
def test_agent_pool_without_codebase_index():
    """Test that agent pool works when codebase_index is None."""
    # Create pool without index
    pool = AgentPoolManager(
        project_id=1,
        db=mock_db,
        codebase_index=None
    )
    
    # Create backend agent
    agent_id = pool.create_agent("backend")
    agent = pool.get_agent_instance(agent_id)
    
    # Verify agent has None index
    assert agent.codebase_index is None
    
    # Verify agent can still be used
    task = {"id": 1, "title": "Test", "description": "Test"}
    context = agent.build_context(task)
    assert context is not None
```

### 7. Run E2E Tests to Verify Fix

**Action:**
- Execute E2E tests with tasks 868, 869, 871
- Confirm they no longer fail with NoneType error
- Verify warning logs appear for missing codebase_index

**Expected Result:**
- Tasks execute successfully
- Warnings logged about missing codebase_index
- No AttributeError exceptions

## Impact Analysis

**Affected Components:**
- `file:codeframe/agents/backend_worker_agent.py` - Add initialization warning
- `file:codeframe/agents/agent_pool_manager.py` - Add debug logging
- `file:codeframe/agents/frontend_worker_agent.py` - Audit for null-safety
- `file:codeframe/agents/test_worker_agent.py` - Audit for null-safety
- `file:codeframe/agents/review_worker_agent.py` - Audit for null-safety
- Test files - Add unit and integration tests

**Behavior Changes:**
- Tasks execute successfully even without codebase index
- Context building gracefully degrades to task title/description only
- Warnings and debug logs for visibility into configuration state
- No breaking changes to existing functionality

**Backward Compatibility:**
- All changes are additive (new logging, new tests)
- Existing code paths remain unchanged
- Graceful degradation when index is unavailable

## Testing Strategy

1. **Unit Tests**: Verify `build_context()` handles None codebase_index
2. **Integration Tests**: Verify agent pool creation and usage with None index
3. **E2E Tests**: Run existing E2E tests with problematic tasks (868, 869, 871)
4. **Log Verification**: Confirm warning and debug messages appear in logs

## Success Criteria

- [ ] No `AttributeError: 'NoneType' object has no attribute 'search_pattern'` errors
- [ ] Tasks 868, 869, 871 execute successfully
- [ ] Warning logs appear when agents are created without codebase_index
- [ ] All new unit and integration tests pass
- [ ] Existing tests continue to pass
- [ ] Code review approved

## Future Enhancements (Phase 2)

- Implement late-binding of `codebase_index` to `AgentPoolManager` after it's built
- Add `set_codebase_index()` method to `AgentPoolManager`
- Update `LeadAgent.build_codebase_index()` to call `agent_pool_manager.set_codebase_index()`
- Consider making `codebase_index` required or building it earlier in initialization

---

Execution Information

Branch: main
Commit: 4d894a6

---

💡 Tips

Supported Commands (Inside Comments)

• Use @traycerai generate to iterate on the previous version of the implementation plan.

Supported Commands (Inside Description)

• Add @traycerai ignore anywhere in the ticket description to prevent this ticket from being processed.
• Add @traycerai branch:<branch-name> anywhere in the ticket description to specify the target branch for the implementation plan.

Community

• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[traycerai]

I have updated the Implementation Plan to reflect the recent changes in the ticket.

Previous Plan

Observations

The issue occurs when BackendWorkerAgent.build_context() attempts to call self.codebase_index.search_pattern() but self.codebase_index is None. This happens because:

1. LeadAgent initializes AgentPoolManager without passing its codebase_index (file:codeframe/agents/lead_agent.py, lines 95-104)
2. AgentPoolManager defaults codebase_index=None (file:codeframe/agents/agent_pool_manager.py, line 83)
3. When creating BackendWorkerAgent, it passes None as codebase_index (file:codeframe/agents/agent_pool_manager.py, lines 500-505)
4. BackendWorkerAgent.build_context() doesn't check if codebase_index is None before calling methods on it (file:codeframe/agents/backend_worker_agent.py, line 242)

Approach

Implement defensive programming with graceful degradation. Add null-safety checks in BackendWorkerAgent.build_context() to handle missing codebase_index, allowing task execution to continue without codebase context. Optionally fix the root cause by passing codebase_index from LeadAgent to AgentPoolManager, though this requires careful consideration of initialization timing since the index may not be built when AgentPoolManager is created.

Implementation Steps

1. Add Defensive Check in BackendWorkerAgent.build_context()

File: file:codeframe/agents/backend_worker_agent.py

Location: Method build_context() around line 242

Changes:

• Before calling self.codebase_index.search_pattern(), check if self.codebase_index is None
• If None, log a warning and set related_symbols to empty list
• Continue with empty context rather than failing
• This allows tasks to execute without codebase context when index is unavailable

Implementation:

# Around line 239-245
search_terms = f"{task.get('title', '')} {task.get('description', '')}"

# Query codebase index for related symbols (with null-safety)
if self.codebase_index is None:
    logger.warning(
        f"Task {task.get('id', 'unknown')} has no codebase_index, "
        "skipping symbol search (context will be limited)"
    )
    related_symbols = []
else:
    related_symbols = self.codebase_index.search_pattern(search_terms)

2. Add Validation Warning in BackendWorkerAgent.init()

File: file:codeframe/agents/backend_worker_agent.py

Location: Method __init__() around line 82-83

Changes:

• After storing self.codebase_index, check if it's None
• Log a warning that context building will be limited
• This provides early visibility into configuration issues

Implementation:

# Around line 82-83
self.db = db
self.codebase_index = codebase_index

# Warn if codebase_index is not provided
if self.codebase_index is None:
    logger.warning(
        "BackendWorkerAgent initialized without codebase_index. "
        "Context building will be limited to task descriptions only."
    )

3. (Optional) Pass codebase_index from LeadAgent to AgentPoolManager

File: file:codeframe/agents/lead_agent.py

Location: AgentPoolManager initialization around lines 95-104

Consideration: This is optional because self.codebase_index may be None at the time AgentPoolManager is created (it's built later via build_codebase_index()). Only implement if you want to support late-binding of the index.

Changes:

• Add codebase_index=self.codebase_index parameter to AgentPoolManager initialization
• Note: This will pass None initially, but could be updated later if AgentPoolManager supports dynamic index updates

Implementation:

# Around lines 95-104
self.agent_pool_manager = AgentPoolManager(
    project_id=project_id,
    db=db,
    ws_manager=ws_manager,
    max_agents=max_agents,
    api_key=api_key,
    use_sdk=use_sdk,
    model=model,
    cwd=project_root,
    codebase_index=self.codebase_index,  # Add this line
)

4. Update Tests to Verify Null-Safety

Files:

• file:tests/agents/test_backend_worker_agent.py
• file:tests/integration/test_backend_worker_agent_integration.py

Changes:

• Add test case for BackendWorkerAgent with codebase_index=None
• Verify that build_context() returns empty related_symbols and related_files
• Verify that task execution continues without error
• Verify warning is logged

Test Structure:

def test_build_context_without_codebase_index():
    """Test that build_context handles missing codebase_index gracefully."""
    # Create agent with codebase_index=None
    # Call build_context()
    # Assert related_symbols is empty list
    # Assert related_files is empty list
    # Assert warning was logged

Impact Analysis

Affected Components:

• file:codeframe/agents/backend_worker_agent.py - Primary fix location
• file:codeframe/agents/lead_agent.py - Optional improvement
• file:codeframe/agents/agent_pool_manager.py - No changes needed (already supports None)

Behavior Changes:

• Tasks will execute successfully even without codebase index
• Context will be limited to task title/description only
• Warnings logged for visibility
• No breaking changes to existing functionality

Testing Priority:

• Unit tests for null-safety in build_context()
• Integration tests for E2E workflow with missing index
• Verify existing tests still pass

Sequence Diagram

sequenceDiagram
    participant LT as LeadAgent
    participant APM as AgentPoolManager
    participant BWA as BackendWorkerAgent
    participant CI as CodebaseIndex

    LT->>APM: create(codebase_index=None)
    APM->>BWA: create(codebase_index=None)
    BWA->>BWA: __init__(codebase_index=None)
    Note over BWA: Log warning: no codebase_index
    
    BWA->>BWA: execute_task(task)
    BWA->>BWA: build_context(task)
    
    alt codebase_index is None
        BWA->>BWA: Log warning
        BWA->>BWA: related_symbols = []
        BWA->>BWA: related_files = []
    else codebase_index exists
        BWA->>CI: search_pattern(search_terms)
        CI-->>BWA: symbols
        BWA->>BWA: Extract file paths
    end
    
    BWA->>BWA: Continue with context
    Note over BWA: Task executes successfully

Loading

Import In IDE

🤖 Prompt for AI Agents

## Observations

The issue occurs when `BackendWorkerAgent.build_context()` attempts to call `self.codebase_index.search_pattern()` but `self.codebase_index` is `None`. This happens because:

1. `LeadAgent` initializes `AgentPoolManager` without passing its `codebase_index` (file:codeframe/agents/lead_agent.py, lines 95-104)
2. `AgentPoolManager` defaults `codebase_index=None` (file:codeframe/agents/agent_pool_manager.py, line 83)
3. When creating `BackendWorkerAgent`, it passes `None` as `codebase_index` (file:codeframe/agents/agent_pool_manager.py, lines 500-505)
4. `BackendWorkerAgent.build_context()` doesn't check if `codebase_index` is `None` before calling methods on it (file:codeframe/agents/backend_worker_agent.py, line 242)

## Approach

Implement defensive programming with graceful degradation. Add null-safety checks in `BackendWorkerAgent.build_context()` to handle missing `codebase_index`, allowing task execution to continue without codebase context. Optionally fix the root cause by passing `codebase_index` from `LeadAgent` to `AgentPoolManager`, though this requires careful consideration of initialization timing since the index may not be built when `AgentPoolManager` is created.

## Implementation Steps

### 1. Add Defensive Check in BackendWorkerAgent.build_context()

**File:** `file:codeframe/agents/backend_worker_agent.py`

**Location:** Method `build_context()` around line 242

**Changes:**
- Before calling `self.codebase_index.search_pattern()`, check if `self.codebase_index` is `None`
- If `None`, log a warning and set `related_symbols` to empty list
- Continue with empty context rather than failing
- This allows tasks to execute without codebase context when index is unavailable

**Implementation:**
```python
# Around line 239-245
search_terms = f"{task.get('title', '')} {task.get('description', '')}"

# Query codebase index for related symbols (with null-safety)
if self.codebase_index is None:
    logger.warning(
        f"Task {task.get('id', 'unknown')} has no codebase_index, "
        "skipping symbol search (context will be limited)"
    )
    related_symbols = []
else:
    related_symbols = self.codebase_index.search_pattern(search_terms)
```

### 2. Add Validation Warning in BackendWorkerAgent.__init__()

**File:** `file:codeframe/agents/backend_worker_agent.py`

**Location:** Method `__init__()` around line 82-83

**Changes:**
- After storing `self.codebase_index`, check if it's `None`
- Log a warning that context building will be limited
- This provides early visibility into configuration issues

**Implementation:**
```python
# Around line 82-83
self.db = db
self.codebase_index = codebase_index

# Warn if codebase_index is not provided
if self.codebase_index is None:
    logger.warning(
        "BackendWorkerAgent initialized without codebase_index. "
        "Context building will be limited to task descriptions only."
    )
```

### 3. (Optional) Pass codebase_index from LeadAgent to AgentPoolManager

**File:** `file:codeframe/agents/lead_agent.py`

**Location:** `AgentPoolManager` initialization around lines 95-104

**Consideration:** This is optional because `self.codebase_index` may be `None` at the time `AgentPoolManager` is created (it's built later via `build_codebase_index()`). Only implement if you want to support late-binding of the index.

**Changes:**
- Add `codebase_index=self.codebase_index` parameter to `AgentPoolManager` initialization
- Note: This will pass `None` initially, but could be updated later if AgentPoolManager supports dynamic index updates

**Implementation:**
```python
# Around lines 95-104
self.agent_pool_manager = AgentPoolManager(
    project_id=project_id,
    db=db,
    ws_manager=ws_manager,
    max_agents=max_agents,
    api_key=api_key,
    use_sdk=use_sdk,
    model=model,
    cwd=project_root,
    codebase_index=self.codebase_index,  # Add this line
)
```

### 4. Update Tests to Verify Null-Safety

**Files:** 
- `file:tests/agents/test_backend_worker_agent.py`
- `file:tests/integration/test_backend_worker_agent_integration.py`

**Changes:**
- Add test case for `BackendWorkerAgent` with `codebase_index=None`
- Verify that `build_context()` returns empty `related_symbols` and `related_files`
- Verify that task execution continues without error
- Verify warning is logged

**Test Structure:**
```python
def test_build_context_without_codebase_index():
    """Test that build_context handles missing codebase_index gracefully."""
    # Create agent with codebase_index=None
    # Call build_context()
    # Assert related_symbols is empty list
    # Assert related_files is empty list
    # Assert warning was logged
```

## Impact Analysis

**Affected Components:**
- `file:codeframe/agents/backend_worker_agent.py` - Primary fix location
- `file:codeframe/agents/lead_agent.py` - Optional improvement
- `file:codeframe/agents/agent_pool_manager.py` - No changes needed (already supports None)

**Behavior Changes:**
- Tasks will execute successfully even without codebase index
- Context will be limited to task title/description only
- Warnings logged for visibility
- No breaking changes to existing functionality

**Testing Priority:**
- Unit tests for null-safety in `build_context()`
- Integration tests for E2E workflow with missing index
- Verify existing tests still pass

## Sequence Diagram

```mermaid
sequenceDiagram
    participant LT as LeadAgent
    participant APM as AgentPoolManager
    participant BWA as BackendWorkerAgent
    participant CI as CodebaseIndex

    LT->>APM: create(codebase_index=None)
    APM->>BWA: create(codebase_index=None)
    BWA->>BWA: __init__(codebase_index=None)
    Note over BWA: Log warning: no codebase_index
    
    BWA->>BWA: execute_task(task)
    BWA->>BWA: build_context(task)
    
    alt codebase_index is None
        BWA->>BWA: Log warning
        BWA->>BWA: related_symbols = []
        BWA->>BWA: related_files = []
    else codebase_index exists
        BWA->>CI: search_pattern(search_terms)
        CI-->>BWA: symbols
        BWA->>BWA: Extract file paths
    end
    
    BWA->>BWA: Continue with context
    Note over BWA: Task executes successfully
```

---

Execution Information

Branch: main
Commit: 9b4790f

New Plan

Observations

The issue occurs when BackendWorkerAgent.build_context() attempts to call self.codebase_index.search_pattern() but self.codebase_index is None. This happens because:

1. LeadAgent initializes AgentPoolManager without passing its codebase_index (file:codeframe/agents/lead_agent.py, lines 97-104)
2. AgentPoolManager defaults codebase_index=None (file:codeframe/agents/agent_pool_manager.py, line 83)
3. When creating BackendWorkerAgent, it passes None as codebase_index (file:codeframe/agents/agent_pool_manager.py, lines 500-505)
4. BackendWorkerAgent.build_context() already has a null-check at lines 242-254, but initialization warning is missing

Approach

Implement defensive programming with graceful degradation across all agent types. Phase 1 focuses on ensuring null-safety checks are in place and adding comprehensive logging for visibility. The existing null-check in BackendWorkerAgent.build_context() (lines 242-254) handles the core issue, but initialization warnings and audit of other agent types are needed. Phase 2 (future) will implement late-binding of codebase_index to AgentPoolManager after it's built.

Implementation Steps

1. Verify BackendWorkerAgent.build_context() Null-Safety

File: file:codeframe/agents/backend_worker_agent.py

Location: Method build_context() around line 242

Current State: Already has null-check at lines 242-254

Verification Action:

• Confirm the null-check exists and properly handles codebase_index=None
• Verify warning message is logged when index is None
• Ensure related_symbols and related_files are set to empty lists when index is None
• No code changes needed if check is already in place

Expected Code Pattern:

# Around line 242-254
if self.codebase_index is None:
    logger.warning(
        f"Task {task.get('id', 'unknown')} has no codebase_index, "
        "skipping symbol search"
    )
    related_symbols = []
    related_files = []
else:
    related_symbols = self.codebase_index.search_pattern(search_terms)
    related_files = list(set(symbol.file_path for symbol in related_symbols))

2. Add Initialization Warning in BackendWorkerAgent.init()

File: file:codeframe/agents/backend_worker_agent.py

Location: Method __init__() around line 83-84

Changes:

• After storing self.codebase_index, check if it's None
• Log a warning that context building will be limited
• This provides early visibility into configuration issues

Implementation:

# Around line 83-84
self.codebase_index = codebase_index

# Warn if codebase_index is not provided
if self.codebase_index is None:
    logger.warning(
        "BackendWorkerAgent initialized without codebase_index. "
        "Context building will be limited to task descriptions only."
    )

3. Add Logging to AgentPoolManager._create_traditional_agent()

File: file:codeframe/agents/agent_pool_manager.py

Location: Lines 500-505 in _create_traditional_agent() method

Changes:

• Add debug logging when creating BackendWorkerAgent with codebase_index=None
• Track when agents are created without index for debugging

Implementation:

# Around lines 500-505
if agent_type == "backend" or agent_type == "backend-worker":
    if self.codebase_index is None:
        logger.debug(
            f"Creating BackendWorkerAgent {agent_id} without codebase_index "
            "(will be available after index is built)"
        )
    return BackendWorkerAgent(
        db=self.db,
        codebase_index=self.codebase_index,
        provider="anthropic",
        api_key=self.api_key,
    )

4. Audit Other Agent Types for Similar Issues

Files to Check:

• file:codeframe/agents/frontend_worker_agent.py
• file:codeframe/agents/test_worker_agent.py
• file:codeframe/agents/review_worker_agent.py

Action:

• Search for any direct access to codebase_index attributes
• Add null-safety checks if found
• Pattern to search: self.codebase_index. without preceding null-check

5. Add Unit Tests for Null-Safety

File: file:tests/agents/test_backend_worker_agent.py

Changes:

• Add test case for BackendWorkerAgent with codebase_index=None
• Verify that build_context() returns empty related_symbols and related_files
• Verify warning is logged

Test Case:

def test_build_context_without_codebase_index():
    """Test that build_context handles missing codebase_index gracefully."""
    # Create agent with codebase_index=None
    agent = BackendWorkerAgent(
        db=mock_db,
        codebase_index=None,
        provider="anthropic",
        api_key="test-key"
    )
    
    # Create test task
    task = {
        "id": 1,
        "title": "Test Task",
        "description": "Test Description"
    }
    
    # Call build_context
    context = agent.build_context(task)
    
    # Assert related_symbols and related_files are empty
    assert context.get("related_symbols") == []
    assert context.get("related_files") == []

6. Add Integration Tests

File: file:tests/integration/test_agent_pool_manager.py

Changes:

• Add test case for agent pool creation without codebase_index
• Verify agents work correctly with None index

Test Case:

def test_agent_pool_without_codebase_index():
    """Test that agent pool works when codebase_index is None."""
    # Create pool without index
    pool = AgentPoolManager(
        project_id=1,
        db=mock_db,
        codebase_index=None
    )
    
    # Create backend agent
    agent_id = pool.create_agent("backend")
    agent = pool.get_agent_instance(agent_id)
    
    # Verify agent has None index
    assert agent.codebase_index is None
    
    # Verify agent can still be used
    task = {"id": 1, "title": "Test", "description": "Test"}
    context = agent.build_context(task)
    assert context is not None

7. Run E2E Tests to Verify Fix

Action:

• Execute E2E tests with tasks 868, 869, 871
• Confirm they no longer fail with NoneType error
• Verify warning logs appear for missing codebase_index

Expected Result:

• Tasks execute successfully
• Warnings logged about missing codebase_index
• No AttributeError exceptions

Impact Analysis

Affected Components:

• file:codeframe/agents/backend_worker_agent.py - Add initialization warning
• file:codeframe/agents/agent_pool_manager.py - Add debug logging
• file:codeframe/agents/frontend_worker_agent.py - Audit for null-safety
• file:codeframe/agents/test_worker_agent.py - Audit for null-safety
• file:codeframe/agents/review_worker_agent.py - Audit for null-safety
• Test files - Add unit and integration tests

Behavior Changes:

• Tasks execute successfully even without codebase index
• Context building gracefully degrades to task title/description only
• Warnings and debug logs for visibility into configuration state
• No breaking changes to existing functionality

Backward Compatibility:

• All changes are additive (new logging, new tests)
• Existing code paths remain unchanged
• Graceful degradation when index is unavailable

Testing Strategy

1. Unit Tests: Verify build_context() handles None codebase_index
2. Integration Tests: Verify agent pool creation and usage with None index
3. E2E Tests: Run existing E2E tests with problematic tasks (868, 869, 871)
4. Log Verification: Confirm warning and debug messages appear in logs

Success Criteria

• No AttributeError: 'NoneType' object has no attribute 'search_pattern' errors
• Tasks 868, 869, 871 execute successfully
• Warning logs appear when agents are created without codebase_index
• All new unit and integration tests pass
• Existing tests continue to pass
• Code review approved

Future Enhancements (Phase 2)

• Implement late-binding of codebase_index to AgentPoolManager after it's built
• Add set_codebase_index() method to AgentPoolManager
• Update LeadAgent.build_codebase_index() to call agent_pool_manager.set_codebase_index()
• Consider making codebase_index required or building it earlier in initialization

Import In IDE

🤖 Prompt for AI Agents

## Observations

The issue occurs when `BackendWorkerAgent.build_context()` attempts to call `self.codebase_index.search_pattern()` but `self.codebase_index` is `None`. This happens because:

1. `LeadAgent` initializes `AgentPoolManager` without passing its `codebase_index` (file:codeframe/agents/lead_agent.py, lines 97-104)
2. `AgentPoolManager` defaults `codebase_index=None` (file:codeframe/agents/agent_pool_manager.py, line 83)
3. When creating `BackendWorkerAgent`, it passes `None` as `codebase_index` (file:codeframe/agents/agent_pool_manager.py, lines 500-505)
4. `BackendWorkerAgent.build_context()` already has a null-check at lines 242-254, but initialization warning is missing

## Approach

Implement defensive programming with graceful degradation across all agent types. Phase 1 focuses on ensuring null-safety checks are in place and adding comprehensive logging for visibility. The existing null-check in `BackendWorkerAgent.build_context()` (lines 242-254) handles the core issue, but initialization warnings and audit of other agent types are needed. Phase 2 (future) will implement late-binding of `codebase_index` to `AgentPoolManager` after it's built.

## Implementation Steps

### 1. Verify BackendWorkerAgent.build_context() Null-Safety

**File:** `file:codeframe/agents/backend_worker_agent.py`

**Location:** Method `build_context()` around line 242

**Current State:** Already has null-check at lines 242-254

**Verification Action:**
- Confirm the null-check exists and properly handles `codebase_index=None`
- Verify warning message is logged when index is None
- Ensure `related_symbols` and `related_files` are set to empty lists when index is None
- No code changes needed if check is already in place

**Expected Code Pattern:**
```python
# Around line 242-254
if self.codebase_index is None:
    logger.warning(
        f"Task {task.get('id', 'unknown')} has no codebase_index, "
        "skipping symbol search"
    )
    related_symbols = []
    related_files = []
else:
    related_symbols = self.codebase_index.search_pattern(search_terms)
    related_files = list(set(symbol.file_path for symbol in related_symbols))
```

### 2. Add Initialization Warning in BackendWorkerAgent.__init__()

**File:** `file:codeframe/agents/backend_worker_agent.py`

**Location:** Method `__init__()` around line 83-84

**Changes:**
- After storing `self.codebase_index`, check if it's `None`
- Log a warning that context building will be limited
- This provides early visibility into configuration issues

**Implementation:**
```python
# Around line 83-84
self.codebase_index = codebase_index

# Warn if codebase_index is not provided
if self.codebase_index is None:
    logger.warning(
        "BackendWorkerAgent initialized without codebase_index. "
        "Context building will be limited to task descriptions only."
    )
```

### 3. Add Logging to AgentPoolManager._create_traditional_agent()

**File:** `file:codeframe/agents/agent_pool_manager.py`

**Location:** Lines 500-505 in `_create_traditional_agent()` method

**Changes:**
- Add debug logging when creating BackendWorkerAgent with `codebase_index=None`
- Track when agents are created without index for debugging

**Implementation:**
```python
# Around lines 500-505
if agent_type == "backend" or agent_type == "backend-worker":
    if self.codebase_index is None:
        logger.debug(
            f"Creating BackendWorkerAgent {agent_id} without codebase_index "
            "(will be available after index is built)"
        )
    return BackendWorkerAgent(
        db=self.db,
        codebase_index=self.codebase_index,
        provider="anthropic",
        api_key=self.api_key,
    )
```

### 4. Audit Other Agent Types for Similar Issues

**Files to Check:**
- `file:codeframe/agents/frontend_worker_agent.py`
- `file:codeframe/agents/test_worker_agent.py`
- `file:codeframe/agents/review_worker_agent.py`

**Action:**
- Search for any direct access to `codebase_index` attributes
- Add null-safety checks if found
- Pattern to search: `self.codebase_index.` without preceding null-check

### 5. Add Unit Tests for Null-Safety

**File:** `file:tests/agents/test_backend_worker_agent.py`

**Changes:**
- Add test case for `BackendWorkerAgent` with `codebase_index=None`
- Verify that `build_context()` returns empty `related_symbols` and `related_files`
- Verify warning is logged

**Test Case:**
```python
def test_build_context_without_codebase_index():
    """Test that build_context handles missing codebase_index gracefully."""
    # Create agent with codebase_index=None
    agent = BackendWorkerAgent(
        db=mock_db,
        codebase_index=None,
        provider="anthropic",
        api_key="test-key"
    )
    
    # Create test task
    task = {
        "id": 1,
        "title": "Test Task",
        "description": "Test Description"
    }
    
    # Call build_context
    context = agent.build_context(task)
    
    # Assert related_symbols and related_files are empty
    assert context.get("related_symbols") == []
    assert context.get("related_files") == []
```

### 6. Add Integration Tests

**File:** `file:tests/integration/test_agent_pool_manager.py`

**Changes:**
- Add test case for agent pool creation without codebase_index
- Verify agents work correctly with None index

**Test Case:**
```python
def test_agent_pool_without_codebase_index():
    """Test that agent pool works when codebase_index is None."""
    # Create pool without index
    pool = AgentPoolManager(
        project_id=1,
        db=mock_db,
        codebase_index=None
    )
    
    # Create backend agent
    agent_id = pool.create_agent("backend")
    agent = pool.get_agent_instance(agent_id)
    
    # Verify agent has None index
    assert agent.codebase_index is None
    
    # Verify agent can still be used
    task = {"id": 1, "title": "Test", "description": "Test"}
    context = agent.build_context(task)
    assert context is not None
```

### 7. Run E2E Tests to Verify Fix

**Action:**
- Execute E2E tests with tasks 868, 869, 871
- Confirm they no longer fail with NoneType error
- Verify warning logs appear for missing codebase_index

**Expected Result:**
- Tasks execute successfully
- Warnings logged about missing codebase_index
- No AttributeError exceptions

## Impact Analysis

**Affected Components:**
- `file:codeframe/agents/backend_worker_agent.py` - Add initialization warning
- `file:codeframe/agents/agent_pool_manager.py` - Add debug logging
- `file:codeframe/agents/frontend_worker_agent.py` - Audit for null-safety
- `file:codeframe/agents/test_worker_agent.py` - Audit for null-safety
- `file:codeframe/agents/review_worker_agent.py` - Audit for null-safety
- Test files - Add unit and integration tests

**Behavior Changes:**
- Tasks execute successfully even without codebase index
- Context building gracefully degrades to task title/description only
- Warnings and debug logs for visibility into configuration state
- No breaking changes to existing functionality

**Backward Compatibility:**
- All changes are additive (new logging, new tests)
- Existing code paths remain unchanged
- Graceful degradation when index is unavailable

## Testing Strategy

1. **Unit Tests**: Verify `build_context()` handles None codebase_index
2. **Integration Tests**: Verify agent pool creation and usage with None index
3. **E2E Tests**: Run existing E2E tests with problematic tasks (868, 869, 871)
4. **Log Verification**: Confirm warning and debug messages appear in logs

## Success Criteria

- [ ] No `AttributeError: 'NoneType' object has no attribute 'search_pattern'` errors
- [ ] Tasks 868, 869, 871 execute successfully
- [ ] Warning logs appear when agents are created without codebase_index
- [ ] All new unit and integration tests pass
- [ ] Existing tests continue to pass
- [ ] Code review approved

## Future Enhancements (Phase 2)

- Implement late-binding of `codebase_index` to `AgentPoolManager` after it's built
- Add `set_codebase_index()` method to `AgentPoolManager`
- Update `LeadAgent.build_codebase_index()` to call `agent_pool_manager.set_codebase_index()`
- Consider making `codebase_index` required or building it earlier in initialization

---

Execution Information

Branch: main
Commit: 4d894a6

[frankbria]

Fixed in commit 6c1abba. Added null check for codebase_index in BackendWorkerAgent.build_context() - now returns empty lists with warning log instead of raising AttributeError.