v1 TestWorkerAgent writes into codeframe repo instead of target workspace

[frankbria]

Problem

codeframe/agents/test_worker_agent.py hardcodes its output directory to the codeframe repo itself:

# Line 74
self.project_root = Path(__file__).parent.parent.parent
self.tests_dir = self.project_root / "tests"

This means any time the test worker agent runs — even for a completely different project — it writes files into codeframe/tests/. The most visible symptom is tests/test_new_feature.py reappearing after deletion, because the fallback test name is hardcoded:

# Line 262
test_name = "test_new_feature"  # default when task description can't be parsed

Impact

• tests/test_new_feature.py keeps reappearing (deleted 3-4 times, keeps coming back)
• The agent could silently overwrite real test files in the codeframe repo
• Violates v2 architecture rule: agents should operate on the target workspace, not the tool's own repo

Root Cause

TestWorkerAgent is v1 legacy code that predates the v2 workspace architecture. It doesn't accept a Workspace parameter — it uses Path(__file__) to find its output directory.

Affected files

• codeframe/agents/test_worker_agent.py — hardcoded project_root and tests_dir
• codeframe/agents/worker_agent.py — parent class, also v1 legacy
• codeframe/agents/agent_pool_manager.py — only consumer of TestWorkerAgent

Suggested Fix

Two options (not mutually exclusive):

1. Quick fix: Make TestWorkerAgent.__init__ accept a project_root parameter instead of deriving it from __file__. Fall back to current behavior only if not provided.

2. Proper fix: Since this is v1 legacy code not used by the Golden Path, consider marking it deprecated or removing it entirely. The v2 ReactAgent handles test generation as part of its general execution flow.

Workaround

tests/test_new_feature.py has been added to .gitignore so it won't show up in git status anymore.

Labels

• bug
• v1-legacy

[traycerai]

Plan

Observations

The TestWorkerAgent is v1 legacy code that hardcodes its output directory to the codeframe repository itself using Path(__file__).parent.parent.parent. This causes test files to be written into codeframe/tests/ regardless of which project is being worked on. The v2 architecture uses a Workspace object with a repo_path attribute to specify the target repository, but TestWorkerAgent predates this pattern and doesn't accept workspace information. The AgentPoolManager creates TestWorkerAgent instances without passing any workspace or project root parameter.

Approach

Implement a backward-compatible fix by adding an optional project_root parameter to TestWorkerAgent.__init__(). This allows the agent to write tests to the correct workspace while maintaining compatibility with existing code that doesn't pass this parameter. Update AgentPoolManager._create_traditional_agent() to pass the workspace path when creating test agents. This approach follows the principle of minimal change while fixing the immediate bug, and can serve as a stepping stone toward full v2 migration or deprecation.

Implementation Steps

1. Update TestWorkerAgent Constructor

File: file:codeframe/agents/test_worker_agent.py

Modify the __init__ method (lines 40-76) to accept an optional project_root parameter:

• Add project_root: Optional[Path] = None parameter after max_correction_attempts
• Update the initialization logic (lines 74-75):
  • If project_root is provided, use it directly
  • Otherwise, fall back to current behavior: Path(__file__).parent.parent.parent
• Add a docstring note explaining the parameter is for specifying the target workspace
• Import Path from pathlib if not already imported (it is on line 15)

2. Update AgentPoolManager to Pass Workspace Path

File: file:codeframe/agents/agent_pool_manager.py

Modify the _create_traditional_agent method (lines 483-529) to pass project_root when creating TestWorkerAgent:

• Add logic to determine the workspace path:
  • Check if self.cwd is set (it's initialized on line 106)
  • Convert self.cwd to a Path object
• Update the TestWorkerAgent instantiation (lines 514-521):
  • Add project_root=Path(self.cwd) parameter
• Ensure this only affects test agent creation, not other agent types

3. Update AgentPoolManager Constructor Documentation

File: file:codeframe/agents/agent_pool_manager.py

Update the docstring for __init__ (lines 85-98) to clarify:

• The cwd parameter is used as the workspace path for traditional agents
• This ensures test files are written to the correct project directory
• Add a note that this is particularly important for TestWorkerAgent

4. Update Test Fixtures

File: file:tests/agents/test_test_worker_agent.py

Update the test_agent fixture (lines 20-26) to use the new parameter:

• Instead of manually overriding agent.tests_dir and agent.project_root after creation
• Pass project_root=temp_tests_dir.parent to the constructor
• This validates the new parameter works correctly
• Remove the manual attribute assignments (lines 24-25)

5. Add Integration Test

File: file:tests/agents/test_test_worker_agent.py

Add a new test class to verify workspace isolation:

• Create a test that instantiates TestWorkerAgent with a custom project_root
• Verify that _create_test_file writes to the correct directory
• Verify that _analyze_target_code reads from the correct directory
• Ensure the agent doesn't write to the codeframe repo directory

6. Update .gitignore (Optional Cleanup)

File: file:.gitignore

The issue mentions tests/test_new_feature.py was added to .gitignore as a workaround. After this fix is deployed:

• Consider removing this entry if it was added specifically for this issue
• Add a comment explaining why it was removed (bug fix in TestWorkerAgent)
• This is optional and can be done in a follow-up cleanup

Architecture Diagram

sequenceDiagram
    participant APM as AgentPoolManager
    participant TWA as TestWorkerAgent
    participant FS as File System
    
    Note over APM: User requests test agent<br/>for workspace /path/to/project
    
    APM->>TWA: __init__(agent_id, project_root=/path/to/project)
    TWA->>TWA: Set self.project_root = project_root
    TWA->>TWA: Set self.tests_dir = project_root / "tests"
    
    Note over TWA: Agent executes task
    
    TWA->>FS: Read target code from /path/to/project/src/module.py
    TWA->>TWA: Generate test code
    TWA->>FS: Write test to /path/to/project/tests/test_module.py
    
    Note over FS: Test written to correct workspace,<br/>NOT to codeframe repo

Loading

Validation Checklist

After implementation, verify:

• TestWorkerAgent can be instantiated without project_root (backward compatibility)
• TestWorkerAgent uses provided project_root when specified
• AgentPoolManager passes workspace path to test agents
• Test files are created in the target workspace, not codeframe repo
• Existing tests pass with updated fixture
• New integration test validates workspace isolation
• tests/test_new_feature.py no longer appears after running test agent

Import In IDE

🤖 Prompt for AI Agents

## Observations

The `TestWorkerAgent` is v1 legacy code that hardcodes its output directory to the codeframe repository itself using `Path(__file__).parent.parent.parent`. This causes test files to be written into `codeframe/tests/` regardless of which project is being worked on. The v2 architecture uses a `Workspace` object with a `repo_path` attribute to specify the target repository, but `TestWorkerAgent` predates this pattern and doesn't accept workspace information. The `AgentPoolManager` creates `TestWorkerAgent` instances without passing any workspace or project root parameter.

## Approach

Implement a backward-compatible fix by adding an optional `project_root` parameter to `TestWorkerAgent.__init__()`. This allows the agent to write tests to the correct workspace while maintaining compatibility with existing code that doesn't pass this parameter. Update `AgentPoolManager._create_traditional_agent()` to pass the workspace path when creating test agents. This approach follows the principle of minimal change while fixing the immediate bug, and can serve as a stepping stone toward full v2 migration or deprecation.

## Implementation Steps

### 1. Update TestWorkerAgent Constructor

**File:** `file:codeframe/agents/test_worker_agent.py`

Modify the `__init__` method (lines 40-76) to accept an optional `project_root` parameter:

- Add `project_root: Optional[Path] = None` parameter after `max_correction_attempts`
- Update the initialization logic (lines 74-75):
  - If `project_root` is provided, use it directly
  - Otherwise, fall back to current behavior: `Path(__file__).parent.parent.parent`
- Add a docstring note explaining the parameter is for specifying the target workspace
- Import `Path` from `pathlib` if not already imported (it is on line 15)

### 2. Update AgentPoolManager to Pass Workspace Path

**File:** `file:codeframe/agents/agent_pool_manager.py`

Modify the `_create_traditional_agent` method (lines 483-529) to pass `project_root` when creating `TestWorkerAgent`:

- Add logic to determine the workspace path:
  - Check if `self.cwd` is set (it's initialized on line 106)
  - Convert `self.cwd` to a `Path` object
- Update the `TestWorkerAgent` instantiation (lines 514-521):
  - Add `project_root=Path(self.cwd)` parameter
- Ensure this only affects test agent creation, not other agent types

### 3. Update AgentPoolManager Constructor Documentation

**File:** `file:codeframe/agents/agent_pool_manager.py`

Update the docstring for `__init__` (lines 85-98) to clarify:

- The `cwd` parameter is used as the workspace path for traditional agents
- This ensures test files are written to the correct project directory
- Add a note that this is particularly important for `TestWorkerAgent`

### 4. Update Test Fixtures

**File:** `file:tests/agents/test_test_worker_agent.py`

Update the `test_agent` fixture (lines 20-26) to use the new parameter:

- Instead of manually overriding `agent.tests_dir` and `agent.project_root` after creation
- Pass `project_root=temp_tests_dir.parent` to the constructor
- This validates the new parameter works correctly
- Remove the manual attribute assignments (lines 24-25)

### 5. Add Integration Test

**File:** `file:tests/agents/test_test_worker_agent.py`

Add a new test class to verify workspace isolation:

- Create a test that instantiates `TestWorkerAgent` with a custom `project_root`
- Verify that `_create_test_file` writes to the correct directory
- Verify that `_analyze_target_code` reads from the correct directory
- Ensure the agent doesn't write to the codeframe repo directory

### 6. Update .gitignore (Optional Cleanup)

**File:** `file:.gitignore`

The issue mentions `tests/test_new_feature.py` was added to `.gitignore` as a workaround. After this fix is deployed:

- Consider removing this entry if it was added specifically for this issue
- Add a comment explaining why it was removed (bug fix in TestWorkerAgent)
- This is optional and can be done in a follow-up cleanup

## Architecture Diagram

```mermaid
sequenceDiagram
    participant APM as AgentPoolManager
    participant TWA as TestWorkerAgent
    participant FS as File System
    
    Note over APM: User requests test agent<br/>for workspace /path/to/project
    
    APM->>TWA: __init__(agent_id, project_root=/path/to/project)
    TWA->>TWA: Set self.project_root = project_root
    TWA->>TWA: Set self.tests_dir = project_root / "tests"
    
    Note over TWA: Agent executes task
    
    TWA->>FS: Read target code from /path/to/project/src/module.py
    TWA->>TWA: Generate test code
    TWA->>FS: Write test to /path/to/project/tests/test_module.py
    
    Note over FS: Test written to correct workspace,<br/>NOT to codeframe repo
```

## Validation Checklist

After implementation, verify:

- [ ] `TestWorkerAgent` can be instantiated without `project_root` (backward compatibility)
- [ ] `TestWorkerAgent` uses provided `project_root` when specified
- [ ] `AgentPoolManager` passes workspace path to test agents
- [ ] Test files are created in the target workspace, not codeframe repo
- [ ] Existing tests pass with updated fixture
- [ ] New integration test validates workspace isolation
- [ ] `tests/test_new_feature.py` no longer appears after running test agent

---

Execution Information

Branch: main
Commit: 36c8fc2

---

💡 Tips

Supported Commands (Inside Comments)

• Use @traycerai generate to iterate on the previous version of the implementation plan.

Supported Commands (Inside Description)

• Add @traycerai ignore anywhere in the ticket description to prevent this ticket from being processed.
• Add @traycerai branch:<branch-name> anywhere in the ticket description to specify the target branch for the implementation plan.

Community

• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

🔗 Related PRs

#22 - fix: Reorganize test suite and fix API test failures [merged]
#37 - feat: Multi-agent per project architecture (Phases 1-5) [merged]
#77 - fix: Add explicit workspace cleanup on project creation failure [merged]
#151 - Integrate QualityTracker with workflow system [merged]
#267 - fix: standardize worker agent task dict interface [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[frankbria]

Closing: v1 TestWorkerAgent bug. v2 agents use core/react_agent.py with proper workspace scoping. v1 agent code is reference only.