chore(tests): remove orphaned v1 tests for removed /api/projects endpoint - #667
Conversation
…oint test_project_creation_api.py (cf-11) and test_workspace_cleanup.py (Issue #7) exercise the v1 POST /api/projects route removed in 66241c2 (remove orphaned v1 web layer). No v2 marker, so CI's -m v2 suite never ran them; they 404 on a full local run. Dead weight. v2-equivalent coverage lives in tests/ui. Kept tests/cli/test_api_client.py (mocked CLI client helper, still passes).
|
Warning Review limit reached
More reviews will be available in 1 hour, 42 minutes, and 34 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code ReviewVerdict: Approve — clean, well-justified deletion. What this PR doesRemoves 496 lines across two dead test files that targeted the v1 Verification
One minor noteThe PR description mentions the broader CI blind spot (~535 tests without a No production code is touched. Deletions only. LGTM. |
* fix(ci): run full non-e2e suite in CI, drop -m v2 blind spot (#669) The backend CI gate ran `pytest -m v2`, but the root conftest never auto-marked v2, so ~514 legit tests (40% of files) were silently deselected and never gated a PR. The v1->v2 refactor that the filter existed for is done. Categorized the 514 deselected tests: 497 pass, 16 skip, 1 is a real-LLM `lifecycle` test (correctly excluded). No dead tests remain (the v1 /api/projects pair was removed in #667). Changes: - CI: `-m v2` -> `-m "not lifecycle"` so every non-e2e test gates PRs; only real-LLM lifecycle tests (run locally via scripts/lifecycle) are excluded. Timeout 15->20m for the ~500 extra tests under coverage. - pytest.ini: document the new two-tier gate; v2 marker kept for back-compat but no longer gates. - tests/auth/test_query_param_token.py: sign JWTs with the LIVE manager.SECRET instead of the import-time binding. Un-hiding the suite surfaced this order-dependent flake: any test that starts the app via TestClient refreshes SECRET from .env (lifespan), which made import-bound tokens unverifiable. Full non-e2e run: 3830 passed, 11 skipped, 6 deselected (lifecycle), 0 failed. * docs: point CLAUDE.md test commands at the new CI gate (#669) * docs: match CI gate command to workflow (explicit tests/) (#669)
What
Deletes two orphaned test files targeting the v1
POST /api/projectsendpoint, removed in 66241c2 (refactor: remove orphaned v1 web layer):tests/api/test_project_creation_api.py(task cf-11)tests/api/test_workspace_cleanup.py(Issue Improve workspace cleanup in project creation rollback #7)Why
The route no longer exists, so these fail with 404 on a full local run. They carry no
v2marker, so CI's-m v2suite never ran them — silently dead since the v1 web layer was removed. v2-equivalent coverage lives undertests/ui/.tests/cli/test_api_client.pyis intentionally kept (mocked CLI client-helper tests; still passes).Scope note
Narrow cleanup. The broader CI blind spot —
-m v2deselects ~535 tests (~40% of files lack the marker) — is tracked in a separate issue.Deletions only; no production code changed.