hung window cleanup, improved code docs. Fixes #163#165
Merged
codecounselor merged 2 commits intofraserxu:masterfrom Feb 9, 2017
Merged
hung window cleanup, improved code docs. Fixes #163#165codecounselor merged 2 commits intofraserxu:masterfrom
codecounselor merged 2 commits intofraserxu:masterfrom
Conversation
mattsgarlata
reviewed
Feb 8, 2017
lib/exportJob.js
Outdated
| // CONSTANTS | ||
| /** Used to calculate browser dimensions based on PDF size */ | ||
| const HTML_DPI = 96 | ||
| /** Interval for which to check for hung windows */ |
There was a problem hiding this comment.
I think it would be helpful to list the units, and what 30,000 translates into. Same comment for HUNG_WINDOW_THRESHOLD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.