[IDEA] List installation requirements

[cyril-marpaud]

It'd probably be a good idea to list veshell's installation requirements and process.

I'm running Ubuntu 22.04 and I was asked to install libseat (sudo apt install libseat-dev).

I'm also facing this compilation error (which can be corrected by making the suggested change):

Then I faced this one, which I didn't investigate:

[PapyElGringo]

Thanks I added a link in the main readme to https://github.com/free-explorers/veshell/blob/main/docs/dependencies.md

Can you attach the whole logs without any code modifications?

You can reset the repository to fresh state after a git pull then git clean -fdx

Thanks in advance !

[cyril-marpaud]

> cargo run
   Compiling veshell v0.1.0 (/home/ash/Repos/veshell)
error: environment variable `CARGO_MANIFEST_PATH` not defined at compile time
  --> extra/build/flutter_sdk.rs:19:24
   |
19 |         .manifest_path(env!("CARGO_MANIFEST_PATH"))
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: Cargo sets build script variables at run time. Use `std::env::var("CARGO_MANIFEST_PATH")` instead
   = note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `veshell` (build script) due to 1 previous error

That enough ?

[PapyElGringo]

It's seems that even if you fix the new env syntax the CARGO_MANIFEST_PATH is not defined at build time :(

regarding the docs it's seems valid https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts

Do you use the nightly version of Rust?

[cyril-marpaud]

No I'm on stable & you're right, the variable seems unset =/

[PapyElGringo]

Can you check the CARGO_MANIFEST_DIR variable aswell?

[cyril-marpaud]

> git diff
diff --git a/extra/build/flutter_sdk.rs b/extra/build/flutter_sdk.rs
index ea33eba..64131e5 100644
--- a/extra/build/flutter_sdk.rs
+++ b/extra/build/flutter_sdk.rs
@@ -16,7 +16,7 @@ pub fn install_flutter_sdk() -> Result<(), Box<dyn std::error::Error>> {
     }
 
     let _metadata = MetadataCommand::new()
-        .manifest_path(env!("CARGO_MANIFEST_PATH"))
+        .manifest_path(std::env::var("CARGO_MANIFEST_DIR").unwrap())
         .exec()
         .unwrap();
 
> cargo run
   Compiling veshell v0.1.0 (/home/ash/Repos/veshell)
error: failed to run custom build command for `veshell v0.1.0 (/home/ash/Repos/veshell)`

Caused by:
  process didn't exit successfully: `/home/ash/Repos/veshell/build/target/debug/build/veshell-301b78954ac63560/build-script-mod` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=Cargo.toml
  cargo:rerun-if-changed=extra/build/mod.rs
  cargo:rustc-env=CARGO_PROFILE=debug
  cargo:rerun-if-changed=extra/build/flutter_sdk.rs
  cargo:rerun-if-changed=.flutter_sdk/version

  --- stderr
  thread 'main' panicked at extra/build/flutter_sdk.rs:21:10:
  called `Result::unwrap()` on an `Err` value: CargoMetadata { stderr: "error: the manifest-path must be a path to a Cargo.toml file\n" }
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[PapyElGringo]

Sorry the CARGO_MANIFEST_DIR is only a path to a directory, I just wanted to see if it was set you can put in flutter_sdk.rs

    // Print both ENV and panic to show logs
    println!(
        "CARGO_MANIFEST_PATH {}",
        env::var("CARGO_MANIFEST_PATH").unwrap()
    );
    println!(
        "CARGO_MANIFEST_DIR {}",
        env::var("CARGO_MANIFEST_DIR").unwrap()
    );
    panic!();

if the CARGO_MANIFEST_DIR is set we can rebuild the path adding it the Cargo.toml to it as fallback

[cyril-marpaud]

> git diff
diff --git a/extra/build/flutter_sdk.rs b/extra/build/flutter_sdk.rs
index ea33eba..5610165 100644
--- a/extra/build/flutter_sdk.rs
+++ b/extra/build/flutter_sdk.rs
@@ -15,8 +15,18 @@ pub fn install_flutter_sdk() -> Result<(), Box<dyn std::error::Error>> {
             .status()?;
     }
 
+    // Print both ENV and panic to show logs
+    println!(
+        "CARGO_MANIFEST_PATH {:?}",
+        std::env::var("CARGO_MANIFEST_PATH")
+    );
+    println!(
+        "CARGO_MANIFEST_DIR {:?}",
+        std::env::var("CARGO_MANIFEST_DIR")
+    );
+
     let _metadata = MetadataCommand::new()
-        .manifest_path(env!("CARGO_MANIFEST_PATH"))
+        .manifest_path(std::env::var("CARGO_MANIFEST_PATH").unwrap())
         .exec()
         .unwrap();
 
> cargo run
   Compiling veshell v0.1.0 (/home/ash/Repos/veshell)
error: failed to run custom build command for `veshell v0.1.0 (/home/ash/Repos/veshell)`

Caused by:
  process didn't exit successfully: `/home/ash/Repos/veshell/build/target/debug/build/veshell-45530922d8cbc0a3/build-script-mod` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=Cargo.toml
  cargo:rerun-if-changed=extra/build/mod.rs
  cargo:rustc-env=CARGO_PROFILE=debug
  cargo:rerun-if-changed=extra/build/flutter_sdk.rs
  cargo:rerun-if-changed=.flutter_sdk/version
  CARGO_MANIFEST_PATH Err(NotPresent)
  CARGO_MANIFEST_DIR Ok("/home/ash/Repos/veshell")

  --- stderr
  thread 'main' panicked at extra/build/flutter_sdk.rs:29:61:
  called `Result::unwrap()` on an `Err` value: NotPresent
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The variable does not look like its present.

[PapyElGringo]

Ok I just pushed a fallback let me know if it works now

[cyril-marpaud]

It looks like it works but you might wanna use unwrap_or_else.
I'm hitting another error later in the build process, I think I'm missing some dependencies like clang. I need a bit of time to get back to you.

[cyril-marpaud]

Looks like libstdc++-12-dev is also required
And now I'm facing this one:

  Building Linux application...                                   
  Command executed: ExitStatus(unix_wait_status(256))

  --- stderr
  CMake Error at /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:603 (message):
    A required package was not found
  Call Stack (most recent call first):
    /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:825 (_pkg_check_modules_internal)
    flutter/CMakeLists.txt:25 (pkg_check_modules)


  Unable to generate build files
  thread 'main' panicked at extra/build/shell.rs:61:9:
  Failed to build shell
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[PapyElGringo]

So you got the error even after installing libstdc++-12-dev ?

Can you also try from workspace dir

cd src/shell
../../.flutter_sdk/bin/flutter build linux

[cyril-marpaud]

Installing libstdc++-12-dev solves one issue, but another one arises.
I've tried to run your commands, here's the output:

> cd src/shell
> ../../.flutter_sdk/bin/flutter build linux

CMake Error at /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:603 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:825 (_pkg_check_modules_internal)
  flutter/CMakeLists.txt:25 (pkg_check_modules)

Building Linux application...                                           
Unable to generate build files